From owner-freebsd-bugs@FreeBSD.ORG Thu Feb 21 19:10:01 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id A5E9C428 for ; Thu, 21 Feb 2013 19:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 7506E25D for ; Thu, 21 Feb 2013 19:10:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r1LJA1ej008559 for ; Thu, 21 Feb 2013 19:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r1LJA1sS008558; Thu, 21 Feb 2013 19:10:01 GMT (envelope-from gnats) Resent-Date: Thu, 21 Feb 2013 19:10:01 GMT Resent-Message-Id: <201302211910.r1LJA1sS008558@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Glen Barber Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id D8CEC3E3 for ; Thu, 21 Feb 2013 19:08:45 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id CB182247 for ; Thu, 21 Feb 2013 19:08:45 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r1LJ8jBR094065 for ; Thu, 21 Feb 2013 19:08:45 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id r1LJ8jK1094064; Thu, 21 Feb 2013 19:08:45 GMT (envelope-from nobody) Message-Id: <201302211908.r1LJ8jK1094064@red.freebsd.org> Date: Thu, 21 Feb 2013 19:08:45 GMT From: Glen Barber To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: bin/176332: [patch] dc(1) - Properly handle '-h' argument X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Feb 2013 19:10:01 -0000 >Number: 176332 >Category: bin >Synopsis: [patch] dc(1) - Properly handle '-h' argument >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Feb 21 19:10:01 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Glen Barber >Release: 10.0-CURRENT r246768 >Organization: >Environment: FreeBSD nucleus 10.0-CURRENT FreeBSD 10.0-CURRENT #60 r246768: Wed Feb 13 14:55:15 EST 2013 root@nucleus:/usr/obj/usr/src/sys/NUCLEUS amd64 >Description: dc(1) manual page advertises '-h' and '--help' as valid arguments, however 'h' is not in the getopt_long() list. gjb@nucleus:~ % dc -h dc: invalid option -- h usage: dc [-hVx] [-e expression] [file] >How-To-Repeat: >Fix: Patch is attached. Patch attached with submission follows: Index: usr.bin/dc/dc.c =================================================================== --- usr.bin/dc/dc.c (revision 247114) +++ usr.bin/dc/dc.c (working copy) @@ -84,7 +84,7 @@ bool extended_regs = false, preproc_done = false; /* accept and ignore a single dash to be 4.4BSD dc(1) compatible */ - while ((ch = getopt_long(argc, argv, "e:f:Vx", long_options, NULL)) != -1) { + while ((ch = getopt_long(argc, argv, "e:f:hVx", long_options, NULL)) != -1) { switch (ch) { case 'e': if (!preproc_done) >Release-Note: >Audit-Trail: >Unformatted: