Date: Wed, 15 Jul 2020 16:26:25 -0700 From: John-Mark Gurney <jmg@funkthat.com> To: freebsd-net@FreeBSD.org Subject: IF_DRV_PREPEND unlocked? Message-ID: <20200715232624.GR4213@funkthat.com>
next in thread | raw e-mail | index | archive | help
I happen to be looking at the implementation of IFQ_DRV_PREPEND, and
unlike IFQ_DRV_DEQUEUE, it doesn't obtain the lock when manipulating
the ifq. I took a brief look at a few drivers, and it looks like some
of them expect that _PREPEND lock the Q like _DEQUEUE does.
This is likely not an issue often, since it's an error path that likely
rarely happens, but we should fix it.
Should we just add the IFQ_LOCK/_UNLOCK to the macro?
Comments or thoughts?
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200715232624.GR4213>