From owner-freebsd-bugs@FreeBSD.ORG Fri Jul 31 16:00:10 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3F29D1065672 for ; Fri, 31 Jul 2009 16:00:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id F392A8FC15 for ; Fri, 31 Jul 2009 16:00:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n6VG0921029114 for ; Fri, 31 Jul 2009 16:00:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n6VG09jn029113; Fri, 31 Jul 2009 16:00:09 GMT (envelope-from gnats) Resent-Date: Fri, 31 Jul 2009 16:00:09 GMT Resent-Message-Id: <200907311600.n6VG09jn029113@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Tobias Brunner Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CDA9A106566B for ; Fri, 31 Jul 2009 15:53:23 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id BB6C88FC08 for ; Fri, 31 Jul 2009 15:53:23 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n6VFrN8o060955 for ; Fri, 31 Jul 2009 15:53:23 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n6VFrN4O060948; Fri, 31 Jul 2009 15:53:23 GMT (envelope-from nobody) Message-Id: <200907311553.n6VFrN4O060948@www.freebsd.org> Date: Fri, 31 Jul 2009 15:53:23 GMT From: Tobias Brunner To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/137309: [ipsec] sequence number in a SADB_X_SPDGET response is set to zero X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jul 2009 16:00:10 -0000 >Number: 137309 >Category: kern >Synopsis: [ipsec] sequence number in a SADB_X_SPDGET response is set to zero >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jul 31 16:00:09 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Tobias Brunner >Release: 7.2-RELEASE >Organization: strongSwan Project >Environment: FreeBSD bsd.localdomain 7.2-RELEASE FreeBSD 7.2-RELEASE #6: Fri Jul 31 16:18:55 CEST 2009 root@bsd.localdomain:/usr/obj/usr/src/sys/IPSEC i386 >Description: A user-land keying daemon can query an IPsec policy by using SADB_X_SPDGET. This request is handled in the function 'key_spdget' in /usr/src/sys/netipsec/key.c. There the function 'key_setdumpsp' is called to generate the actual response. The third parameter of that function specifies the sequence number of the message. It is currently set to zero. In order to be consistent with the behavior of SADB_GET (see function 'key_get', in particular line 5790, in key.c) the third parameter should be changed to the sequence number of the request. >How-To-Repeat: As described above. >Fix: The third parameter of the call to 'key_setdumpsp' (line 2242 in key.c) should be changed to mhp->msg->sadb_msg_seq (i.e. the sequence number of the request). >Release-Note: >Audit-Trail: >Unformatted: