From owner-svn-src-head@freebsd.org Thu Jun 4 13:44:04 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4F9512F4092 for ; Thu, 4 Jun 2020 13:44:04 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49d6Sg6lWjz3b8t for ; Thu, 4 Jun 2020 13:44:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x743.google.com with SMTP id n141so6002564qke.2 for ; Thu, 04 Jun 2020 06:44:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lFGFea7C9/aYHgIqE3GQDRPPnIj3xsOolA8ul0Yv5nc=; b=aYFdl5FqOTzmmD5k1bo4VsAikpOwWrP5EMu+IQ3HkxZ4om7oY1tWCAFgMCIt3ztg5j J/pQKzRW5qfwZZsyaeJo4ADx/YfNJ4UybviwsiyqnlfKTJrUHTpGDaAyka/qqXwQXmed UdkJ4TfD6gXFJF9CuW6Ax9+rtJtIsKP4Nhxya6f47NhVvnq9AEbdOuGn9mU8bTi+gvNx /8uVnHNEammiELod8PbyYYdoV71UCYTiO+05d6E4ec+/h1TVyNXXWfa2hAhFPk/LWD93 Y5bqvKOM0G6fUdmK3wbzIvPVQhY1cv1jfl+sSls7aZt/OaRtiL3ItXM595RAyEa2Fph1 AwtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lFGFea7C9/aYHgIqE3GQDRPPnIj3xsOolA8ul0Yv5nc=; b=lvj9nHs+mgCuuiHiGOHW5dpbpjTW2OUdzX416pYJM6xGLyQIyOF6zY5CqPPMm0rvFm 4WfBKyR4p1+GaRelkIJmHthKVxzGzbd9QQYx587hRkjYgh9JJ0ByCRZ14GWUc40Mp6hV Bb0FRfXuy1+kWdL6gE+foscgG3wtPR9ovSQFcdmDBrdwsd5+l6N/v5F+v0lFCRArylGe f5/Rja7YeftbKE94TlESPH8WCRGPffzJVZCttQzaa3YsIolurUr5sTEH0mLSomV7s8Yr 6e8TGSkln7+zXDHFJeSjUClJvyS7ryVwebEYLTfjKF6oH0WtJ/geXpsYJmfE/0NBnxys 2NlA== X-Gm-Message-State: AOAM531WG4F12pB7/Qw3S21R+uBOWn3aOP40hD2d4EeoZ8/eljZOE4J/ BbJC7uXPx8xiMnKrBLjNNQGjSyIu/xvVVvxTMSs+ZQ== X-Google-Smtp-Source: ABdhPJz0h5lNcdXqcJygyXQnMM50Cfc08A1kPL5j40AiH9PMf5WoqX3ZAIoHQSECU4vmKfyiovQkqw73R0CG5uH6L9A= X-Received: by 2002:a37:9f09:: with SMTP id i9mr4847546qke.60.1591278242373; Thu, 04 Jun 2020 06:44:02 -0700 (PDT) MIME-Version: 1.0 References: <202006041337.054DbVDT026212@gndrsh.dnsmgr.net> In-Reply-To: <202006041337.054DbVDT026212@gndrsh.dnsmgr.net> From: Warner Losh Date: Thu, 4 Jun 2020 07:43:51 -0600 Message-ID: Subject: Re: svn commit: r361775 - in head/sys: dts/arm64/overlays modules/dtb/rpi To: "Rodney W. Grimes" Cc: Pedro Giffuni , Oleksandr Tymoshenko , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 49d6Sg6lWjz3b8t X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=aYFdl5Fq; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::743) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-2.64 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.96)[-0.956]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-0.98)[-0.981]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.70)[-0.698]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::743:from]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2020 13:44:04 -0000 On Thu, Jun 4, 2020 at 7:37 AM Rodney W. Grimes wrote: > > On Thu, Jun 4, 2020 at 6:54 AM Rodney W. Grimes < > freebsd@gndrsh.dnsmgr.net> > > wrote: > > > > > > > > > > On 03/06/2020 19:59, Oleksandr Tymoshenko wrote: > > > > > Rodney W. Grimes (freebsd@gndrsh.dnsmgr.net) wrote: > > > > >> [ Charset UTF-8 unsupported, converting... ] > > > > >>> Author: gonzo > > > > >>> Date: Wed Jun 3 22:18:15 2020 > > > > >>> New Revision: 361775 > > > > >>> URL: https://svnweb.freebsd.org/changeset/base/361775 > > > > >>> > > > > >>> Log: > > > > >>> Add spigen overlay for Raspberry Pi 4 > > > > >>> > > > > >>> Submitted by: gergely.czuczy@harmless.hu > > > > >>> > > > > >>> Added: > > > > >>> head/sys/dts/arm64/overlays/spigen-rpi4.dtso (contents, > props > > > changed) > > > > >>> Modified: > > > > >>> head/sys/modules/dtb/rpi/Makefile > > > > >>> > > > > >>> Added: head/sys/dts/arm64/overlays/spigen-rpi4.dtso > > > > >>> > > > > ============================================================================== > > > > >>> --- /dev/null 00:00:00 1970 (empty, because file is newly > > > added) > > > > >>> +++ head/sys/dts/arm64/overlays/spigen-rpi4.dtso Wed Jun 3 > > > 22:18:15 2020 (r361775) > > > > >>> @@ -0,0 +1,30 @@ > > > > >>> +/* $FreeBSD$ */ > > > > >> This file needs some form of copyright/license. > > > > > Whom should I put as a copyright folder, The FreeBSD Project or the > > > > > person who submitted the patch? > > > > > > > > The person that submitted the patch. > > > > > > > > Note that the FreeBSD Project is not an entity and cannot hold > > > > copyrights (The Foundation can but unless they sponsored it, that > > > > usually involves paperwork). > > > > > > I am glad at least one other person understands that point in law: > > > > > > :root {1002}# find . -type f | xargs grep Copyright | grep -i freebsd | > > > grep -i project > > > ./cddl/compat/opensolaris/kern/opensolaris_dtrace.c: * Copyright 2014 > The > > > FreeBSD Project. > > > ./net/if_enc.h: * Copyright (c) 2008 The FreeBSD Project. > > > ./net/if_enc.c: * Copyright (c) 2006 The FreeBSD Project. > > > ./kern/kern_idle.c: * Copyright (C) 2000-2004 The FreeBSD Project. All > > > rights reserved. > > > > ./kern/subr_kdb.c: * Copyright (c) 2004 The FreeBSD Project > > > > > > > These should be changed to the actual author. > > > > > > > ./conf/newvers.sh: year=$(sed -Ee '/^Copyright .* The FreeBSD > > > Project/!d;s/^.*1992-([0-9]*) .*$/\1/g' ${SYSDIR}/../COPYRIGHT) > > > ./conf/newvers.sh: * Copyright (c) 1992-$year The FreeBSD Project. > > > ./sys/copyright.h: * Copyright (C) 1992-2018 The FreeBSD Project. All > > > rights reserved. > > > ./sys/copyright.h: "Copyright (c) 1992-2019 The FreeBSD > Project.\n" > > > ^^^ The copyright we spit out on every boot :-( > > > > > > > These four are fine. They were cleared by lawyers long ago. This is a > point > > that was extensively litigated during your absence and has been settled > > There was a lawsuit? > > Cleared by which lawyers, you have some documentation of opinion? > There was no lawsuit. I have no written documentation of my conversations. Others were involved in the discussions and the one clear item was for the collection copyright it's fine, since that doesn't protect much since we allow anybody to copy it (the FreeBSD trademark protects much more). For other files, it's not fine because you want traceability to the original sources should there be a dispute about a specific technology. > > practice for a long, long time. Those four instances and /COPYRIGHT are > the > > only places in the tree we should have this, however. > > One can operate outside the law... until one gets caught. As can be > seen just having this copyright statement in the tree has lead to others > to copy it thinking it was ok, and those "tending the house" did not > catch it. > Yes. We didn't. We're not perfect. Now that you've found it, it would be great if you took the initiative to fix the other instances in the tree by digging into svn, contacting the original authors and asking for permission to make the appropriate changes. If you expect someone else to do that work, you'll likely be disappointed. Warner > > > > ./compat/linux/linux_uid16.c: * Copyright (c) 2001 The FreeBSD Project > > > ./tools/embed_mfs.sh:# Copyright (C) 2008 The FreeBSD Project. All > rights > > > reserved. > > > ./dev/mfi/mfi_syspd.c: * Copyright 1994-2009 The FreeBSD > > > Project. > > > ./dev/mfi/mfi_tbolt.c: * Copyright 1994-2009 The FreeBSD > > > Project. > > > ./dev/chromebook_platform/chromebook_platform.c: * Copyright (c) 2016 > The > > > FreeBSD Project. > > > ./dev/pccard/pccarddevs: * Copyright (c) 1999-2004 The FreeBSD Project. > > > ./dev/tdfx/tdfx_linux.c: * Copyright (c) 2006 The FreeBSD Project > > > ./powerpc/powerpc/uma_machdep.c: * Copyright (c) 2003 The FreeBSD > Project > > > ./libkern/memset.c: * Copyright (C) 1992-2007 The FreeBSD Project. All > > > rights reserved. > > > > > > > These are also not fine and should be similarly changed. > > > > It would be a great project for someone to do the svn diving and find who > > committed those files originally and correct it. > > > > Warner > > > > Pedro. > > > -- > > > Rod Grimes > > > rgrimes@freebsd.org > -- > Rod Grimes > rgrimes@freebsd.org >