From owner-freebsd-bugs@FreeBSD.ORG  Fri Nov 11 14:00:32 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 277D3106566B
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 11 Nov 2011 14:00:32 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id DF4AA8FC14
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 11 Nov 2011 14:00:31 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id pABE0VO3016395
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 11 Nov 2011 14:00:31 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id pABE0Vb6016394;
	Fri, 11 Nov 2011 14:00:31 GMT (envelope-from gnats)
Resent-Date: Fri, 11 Nov 2011 14:00:31 GMT
Resent-Message-Id: <201111111400.pABE0Vb6016394@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Alexander Best <arundel@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 688DA106566B
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri, 11 Nov 2011 13:56:09 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 5847F8FC16
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri, 11 Nov 2011 13:56:09 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pABDu9gl084275
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 11 Nov 2011 13:56:09 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id pABDu9ot084273;
	Fri, 11 Nov 2011 13:56:09 GMT (envelope-from nobody)
Message-Id: <201111111356.pABDu9ot084273@red.freebsd.org>
Date: Fri, 11 Nov 2011 13:56:09 GMT
From: Alexander Best <arundel@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: kern/162475: [ath] functions with return type HAL_BOOL (might)
	return HAL_STATUS
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Nov 2011 14:00:32 -0000


>Number:         162475
>Category:       kern
>Synopsis:       [ath] functions with return type HAL_BOOL (might) return HAL_STATUS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 11 14:00:30 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Alexander Best
>Release:        10.0-CURRENT
>Organization:
>Environment:
FreeBSD otaku 10.0-CURRENT FreeBSD 10.0-CURRENT #0: Thu Nov 10 14:01:26 CET 2011     arundel@otaku:/usr/obj/usr/git-freebsd-head/sys/ARUNDEL  amd64
>Description:
in the following functions:

dev/ath/ath_hal/ar5416/ar5416_misc.c:ar5416SetDecompMask()
dev/ath/ath_hal/ar5212/ar5212_misc.c:ar5212SetDecompMask()

the return type is HAL_BOOL, yet it's possible that the return type is HAL_STATUS. Clang(1) complains about this via the -Wconversion warning.

cheers.
alex
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: