From owner-cvs-all@FreeBSD.ORG Sun Apr 24 16:54:58 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 36D1E16A4CE; Sun, 24 Apr 2005 16:54:58 +0000 (GMT) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 009CD43D1D; Sun, 24 Apr 2005 16:54:58 +0000 (GMT) (envelope-from sam@errno.com) Received: from [66.127.85.91] (sam@[66.127.85.91]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id j3OGsvms059101 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 24 Apr 2005 09:54:57 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <426BD00A.6080203@errno.com> Date: Sun, 24 Apr 2005 09:57:46 -0700 From: Sam Leffler User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050327) X-Accept-Language: en-us, en MIME-Version: 1.0 To: src-committers@FreeBSD.org References: <200504241652.j3OGqjcr000905@repoman.freebsd.org> In-Reply-To: <200504241652.j3OGqjcr000905@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys _task.h taskqueue.h src/sys/kern subr_taskqueue.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Apr 2005 16:54:58 -0000 Sam Leffler wrote: > sam 2005-04-24 16:52:45 UTC > > FreeBSD src repository > > Modified files: > sys/sys _task.h taskqueue.h > sys/kern subr_taskqueue.c > Log: > o eliminate modification of task structures after their run to avoid > modify-after-free races when the task structure is malloc'd > o shrink task structure by removing ta_flags (no longer needed with > avoid fix) and combining ta_pending and ta_priority This fixes modify-after-free panics for memory owned by acpitask. It's easy to hit if you use the ath driver on a laptop where acpi is active and load the wireless network. Sam