From owner-svn-src-all@FreeBSD.ORG Thu Feb 6 00:32:33 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 72DA1ABB; Thu, 6 Feb 2014 00:32:33 +0000 (UTC) Received: from mail-gw11.york.ac.uk (mail-gw11.york.ac.uk [144.32.129.150]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2FF8E1C51; Thu, 6 Feb 2014 00:32:33 +0000 (UTC) Received: from ury.york.ac.uk ([144.32.64.162]:39014) by mail-gw11.york.ac.uk with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1WBCnZ-0001SM-OW; Thu, 06 Feb 2014 00:26:33 +0000 Date: Thu, 6 Feb 2014 00:26:33 +0000 (GMT) From: Gavin Atkinson X-X-Sender: gavin@ury.york.ac.uk To: John Baldwin Subject: Re: svn commit: r261216 - head/sys/dev/pccbb In-Reply-To: <201402041424.54122.jhb@freebsd.org> Message-ID: References: <201401271949.s0RJnr7t067977@svn.freebsd.org> <201402041424.54122.jhb@freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, imp@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Feb 2014 00:32:33 -0000 On Tue, 4 Feb 2014, John Baldwin wrote: > On Sunday, February 02, 2014 5:34:58 pm Gavin Atkinson wrote: > > On Mon, 27 Jan 2014, John Baldwin wrote: > > > Author: jhb > > > Date: Mon Jan 27 19:49:52 2014 > > > New Revision: 261216 > > > URL: http://svnweb.freebsd.org/changeset/base/261216 > > > > > > Log: > > > Explicitly enable I/O and memory decoding in the bridge's command register > > > when activating an I/O or memory window on the CardBus bridge. > > > > This fixes some, but not all of my machines. One in particular, a Toshiba > > M5 laptop, remains broken by r254263 even with this change. Specificaly, > > the laptop does not notice when a card is inserted. > > > > The attached minimal patch gets things working again, though I don't know > > if is the correct fix or if a more involved fix is required. > > > > dmesg before and after that patch: > > > > http://people.freebsd.org/~gavin/m5-dmesg-before.txt > > http://people.freebsd.org/~gavin/m5-dmesg-after.txt > > > > The only difference is the cbb register dump, the one bit that I am > > setting in the patch. > > Your patch effectively reverts r254263. It may be the correct thing to do, > but the question is why. :) Can you provide 'pciconf -lbc' output for this > device? (You can just do 'pciconf -lbc pccbb0' in HEAD now) Full "pciconf -lbc" output at http://people.freebsd.org/~gavin/m5-pciconf-lbc.txt It's the same both with and without my hack-patch. Thanks, Gavin