From owner-svn-src-all@FreeBSD.ORG  Wed Oct  1 20:16:59 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 5FE77B11
 for <svn-src-all@freebsd.org>; Wed,  1 Oct 2014 20:16:59 +0000 (UTC)
Received: from mail-qg0-f48.google.com (mail-qg0-f48.google.com
 [209.85.192.48])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 1FD03FCB
 for <svn-src-all@freebsd.org>; Wed,  1 Oct 2014 20:16:58 +0000 (UTC)
Received: by mail-qg0-f48.google.com with SMTP id i50so970020qgf.21
 for <svn-src-all@freebsd.org>; Wed, 01 Oct 2014 13:16:52 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=cJThrLAmqxL/Ddpo/3IF3nLaHQ7qvQNVKSsZFW7dZqo=;
 b=YZz6hB0ETGWvb8MJcWF2tR5R4P0m79DNhj6FwtOoKe78/athoNu5EBi5DYJlEqr1IY
 X7fXtbVpQAvthObAjKv/LVmXYAAcq8ZKjd0TKTdhjGNMOySjjPpLPJ3oR3TZ2/gXW3e8
 XEo2oKhVcG6GVQIHUOGI+MLXulhoiDR9l6ggNTkS5DcmISk2mnVJgQsxJraUViGb9L6z
 /yqf62k+Eo8V0N4dSsYkmTJV/wEqV8NSPGgSvbfkqQBZ4K+EOLqSGuxohq2179rBeF0s
 6LZLIwcT0oglNB3X2hPsYhgFDWY4HQQb0ImPHAs7Qzac5b3CtEZiRs336ub/pfNNL1DF
 EHIw==
X-Gm-Message-State: ALoCoQkvHu6XP5zhct9D0cv+p0W2qAdWIpZPn85SMkuZmIJvpUH+r+gfnvYwXaGFJ4IPeL+WQiFv
MIME-Version: 1.0
X-Received: by 10.224.127.131 with SMTP id g3mr35814371qas.81.1412194612640;
 Wed, 01 Oct 2014 13:16:52 -0700 (PDT)
Received: by 10.140.31.36 with HTTP; Wed, 1 Oct 2014 13:16:52 -0700 (PDT)
In-Reply-To: <CAGHfRMB81gj1k3UPLR0yd7StGBmJPUG1eXRLsVYxbxEqnoSECg@mail.gmail.com>
References: <201409291505.s8TF5Nhh066884@svn.freebsd.org>
 <CAGHfRMB81gj1k3UPLR0yd7StGBmJPUG1eXRLsVYxbxEqnoSECg@mail.gmail.com>
Date: Wed, 1 Oct 2014 14:16:52 -0600
Message-ID: <CADBaqmgG07ZLkb4d8_wLtf2+1xd164j0=AsWooPd-Y0LfnDb1w@mail.gmail.com>
Subject: Re: svn commit: r272282 - head/share/mk
From: Will Andrews <will@firepipe.net>
To: NGie Cooper <yaneurabeya@gmail.com>
Content-Type: text/plain; charset=UTF-8
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Oct 2014 20:16:59 -0000

On Wed, Oct 1, 2014 at 2:03 PM, NGie Cooper <yaneurabeya@gmail.com> wrote:
> This change seems like it introduces a lot of unnecessary complexity
> in lieu of someone setting PORTSDIR to the root of their ports tree in
> the environment.

Sure, but people that are trying to use it somewhere other than
/usr/ports shouldn't be surprised by misbehavior.  I've worked with
several people (who aren't steeped in the usage of ports) who were
astonished by this behavior.

> Why isn't it using a for-loop by the way?

My original implementation used a shell for loop (see the CR), but
given the lack of a legitimate use case for looking farther up than
three parent directories, it seemed easier not to.  I suppose one
could use a static list of paths in the for loop though.

--Will.