From owner-dev-commits-src-main@freebsd.org Mon Feb 8 15:13:13 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D0FDC536927; Mon, 8 Feb 2021 15:13:13 +0000 (UTC) (envelope-from rm@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DZ8fd5cjPz3tFR; Mon, 8 Feb 2021 15:13:13 +0000 (UTC) (envelope-from rm@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1612797193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/X7I1aFh1dY+V51QjXxGOqFYMWC+sC8ZnFdj4sdzpkE=; b=czpC1OLrtGXOdq4ir1glmqIAvT7eUECJsFhw8ehzmd1deShOLEsTmXWujBdIr75SVBvahg 9GaphNqWCH1TgJ7LtIkjZGXsHSImcHrrgt3XQlppcsJtv19UyllhOCs3SmnhmsZMni4xCy 1W4jsx4uO4vQE1jQrfoMxWCLDwGoqSS+Eu9XSVcpA/bMzPf7gQwpda9t+pOHxMPTYzudtO mLWzfSNJ0qbT7igy1DH3iquo4YJhblEgyw2plUEovBRfIfevXjoeRq5anwl+79QvH96/3u +japiznlNvGuOBsCbF+jkWJw5syugU+l75fBF/R8UBXuaVC1tZlzpdW61Iy45g== Received: from [127.0.0.1] (unknown [127.0.1.132]) by freefall.freebsd.org (Postfix) with ESMTP id 09EAF207B; Mon, 8 Feb 2021 15:13:12 +0000 (UTC) (envelope-from rm@FreeBSD.org) Subject: Re: git: 45456abc4ce7 - main - cache: fix trailing slash support in face of permission problems To: Mateusz Guzik , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202102021814.112IEqLa009596@gitrepo.freebsd.org> From: Ruslan Makhmatkhanov Message-ID: <5a2d5e05-e1cf-1b14-c888-c78e83021e71@FreeBSD.org> Date: Mon, 8 Feb 2021 18:13:12 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <202102021814.112IEqLa009596@gitrepo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1612797193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/X7I1aFh1dY+V51QjXxGOqFYMWC+sC8ZnFdj4sdzpkE=; b=DH0K5901+ach1Yq5/lRSmmAiX04KP+VXXpJlgUzIpPrffZN2BXYW+3NMKxk0lMuqQXmTKF M7ZPgZwicGLocISuyGhXaGYo3L2q873cvw2lZ3E1J3if0Lah4ZaCJ4w8CxZCcDC1bMPlax QTy+e/z6HJf0hcOcugrSpa3rgPXtdtL9Jy3l9ru9bB7jWDPSwNW2cLWTW6qu4emAqCYWqM +oH7Pz0lCI2+FlB+VGHHNTHcSG/bHQFS7Ek1d1mWk5z321aa+Y4LqU6VOFqZG/M7vAmMZd amQWF9/bpFf5F+jqicx+ZM5ypNZ4EwZy7KOdhXPmZTby7I3RPIbbV3w0WbcfcQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1612797193; a=rsa-sha256; cv=none; b=WrUF+cQjtl5YliR3nkQdPJeAFdXjimwkOAqLRTSu/yRITViGOMINU9xHRVyp/th+cTmkL8 +1QHyJr9TbtucZ4wJKmbg5dFWSMi/xr32Z3nLrB9OXFMhtwPWs3GiZEhAmL1j8drf6Cuea FyC6mzbhAnfjMqF3li+Q0MIBudNkCgHkyHvBaBKgXdibZlFwhTcJw4ulSa+0EgOA76/zQp IXBjy29ciRSKpTWWjXfkRhdwwSwAY0+XpfAYgaOwMs83PBDDp/xP6qiFkIIq4zY61+gUy2 H4CngnlezuEg/+hCHgOAYIUI851jba+kph51x5sLI6+05smZTBiBD2nV8QhCIg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2021 15:13:13 -0000 Hello, Mateusz Guzik wrote on 2/2/21 9:14 PM: > The branch main has been updated by mjg: > > URL: https://cgit.FreeBSD.org/src/commit/?id=45456abc4ce71053d07cf03ca63bd1ce459fec55 > > commit 45456abc4ce71053d07cf03ca63bd1ce459fec55 > Author: Mateusz Guzik > AuthorDate: 2021-02-02 18:06:56 +0000 > Commit: Mateusz Guzik > CommitDate: 2021-02-02 18:13:51 +0000 > > cache: fix trailing slash support in face of permission problems > > Reported by: Johan Hendriks > Tested by: kevans > --- > sys/kern/vfs_cache.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c > index 7f0e59f1a1ee..db482ea4eba3 100644 > --- a/sys/kern/vfs_cache.c > +++ b/sys/kern/vfs_cache.c > @@ -5521,6 +5521,16 @@ cache_fplookup_failed_vexec(struct cache_fpl *fpl, int error) > dvp = fpl->dvp; > dvp_seqc = fpl->dvp_seqc; > > + /* > + * TODO: Due to ignoring slashes lookup will perform a permission check > + * on the last dir when it should not have. If it fails, we get here. > + * It is possible possible to fix it up fully without resorting to ^^^^^^^^ there is redundant "possible" instance [...] -- Regards, Ruslan T.O.S. Of Reality