From owner-freebsd-usb@FreeBSD.ORG Thu Jul 19 08:28:45 2007 Return-Path: X-Original-To: freebsd-usb@freebsd.org Delivered-To: freebsd-usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7036A16A400 for ; Thu, 19 Jul 2007 08:28:45 +0000 (UTC) (envelope-from markhobden@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.235]) by mx1.freebsd.org (Postfix) with ESMTP id 2937E13C4B6 for ; Thu, 19 Jul 2007 08:28:44 +0000 (UTC) (envelope-from markhobden@gmail.com) Received: by wx-out-0506.google.com with SMTP id i29so387665wxd for ; Thu, 19 Jul 2007 01:28:44 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=mYUhdezmrUcEb9IyOzUGqK1S/uEfS/nuf+svBQGRhuYJEuz9lGb00ETYOi9rYwgG7urEBRXFnuGq+ZVBEFDJqW4MHO3CrD/34O6LlbR0cbJZMV1K9PGFRL2HA6B5W/Q4msyWgip9I+ZXhmhMfI93fr5XLaplrwpQ091YF+P2RpQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Y0eaL9aFQtfIjvJB22UmhEr3dO+Izp6V4dWXqAxm9H1aNlW4VNQTOdsTKWe4JKuc8f3wm+K31JInAWyhoP9BBE/jEJo1boy4RKSO2UJ9nmNmA3kWPslMcfjA763M26GwbbVHkFFdivDzcGrb1fsOc6UDqGimuYcaQscyVO14llI= Received: by 10.90.68.15 with SMTP id q15mr2473601aga.1184833724402; Thu, 19 Jul 2007 01:28:44 -0700 (PDT) Received: by 10.90.117.10 with HTTP; Thu, 19 Jul 2007 01:28:44 -0700 (PDT) Message-ID: Date: Thu, 19 Jul 2007 09:28:44 +0100 From: "Mark Hobden" To: "M. Warner Losh" In-Reply-To: <20070718.203153.112852673.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070718.203153.112852673.imp@bsdimp.com> Cc: freebsd-current@freebsd.org, freebsd-usb@freebsd.org Subject: Re: uhidev(4) update - USB HID driver level for devices with multiple report ids X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2007 08:28:45 -0000 On 19/07/07, M. Warner Losh wrote: > In message: > "Mark Hobden" writes: > : I have updated the uhidev(4) patch from NetBSD to apply to today's 7-CURRENT. > : > : http://www.terinea.co.uk/~mark/patches/uhidev-7-current-p2.diff > > this one seems to be backwards > Sorry Warner, I don't quite get what you mean here. Do you mean that the patch is only wanting to apply with patch -R ?? or does not want to apply in some way? or that I have removed the changes made in ums.c version 1.95. This is the case as the other patch I posted makes them work with the correct report id. I split up the patches to make it a bit clearer how the problem is fixed - I am using a WLNOTEBOOK (0x00b9) mouse right now and they work fine. or have I managed remove functionality somewhere else? Thanks, Mark