From nobody Tue Jan 27 18:44:08 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f0vSn2DWGz6QFn7 for ; Tue, 27 Jan 2026 18:44:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f0vSm6cD9z3rHM for ; Tue, 27 Jan 2026 18:44:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769539449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=esg/tvfr3TyUWY8EQPYMPEz2kn2QQOHqSS5QacSzPwA=; b=ZgeRUGGF81GYradibuMYUNMT0COLrhWH15E+KUCb/28vbUiwSvgcYWu7ISkUJDvVan3psa GTrFG747Aw47j5mCdDcwfOLA1WCnWWUKrdyJ62w4emae+Nl+U9Hjj9V7+XzrYauSg0elGi Ief1++Npx2WdRwH/vpD5v/f7Ecvy918OW/q6Pey5Qk5PWOX9CoUL+S01wGMummXJh1iPNV /J38mV9xBT4VApIF90KP8y/gejbm430/3sFgT3of3NaTTBcHQA4/dt0DzlVim8WtBe/L6v 8cxb8B9/InNrapO2L2f+viWwPjQVDE+MfZjbLbaz2MrWkWxuXIio8zlJoAMDRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769539449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=esg/tvfr3TyUWY8EQPYMPEz2kn2QQOHqSS5QacSzPwA=; b=s9Lx6hnld30U3DzMctb5jLoeS+N5+UKewu4+Rtu53hWmeP8Zbi4aid8reUVobzCns+waN+ mvFnfG0iKQfk/jBBgSEW65SaPgHOR/jhcWqnFhmEJXRS1GBkHVy1v49fa99KBBsgSOX51Y SNE/Q1VBQ9pxVq4s1Oqo7xWIPBOWnHnxLh4IIJA1cLseDpVJHIvDMNIemkOSag7Re41/bW pqnMDE/7FBDycuXOoeyYjWx+MbMu4DUKQIhq7hx/xhIQ6tjKwSBV6ptxYiPGMSVPL2xKFD rIWw6EDLARpFLlTAQyCBjhQZyD9tZT7h6eR6vkYLS9XYB/fJzK4Z2/7Mz6xzKg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769539449; a=rsa-sha256; cv=none; b=m/F4xR67vFKkfgcIEtq0rgQsfz3T6M9af6aPXaVbNrVp+EMXJY+SLdhV0cZ+PZITJyODsz S1LVdEaiylEBbLliD2aoSIVVH5aeB4PAI4FAp8P9W6QZHBqa0NImQszlHzomHs0XK+2yXY ir+k7JgeSAzfcq01svH3XoQSerTL2QKNij4KUT4LCoXcipyLJ35AxY47m+bgmHDOdWMhAW PMOHscG485ERLxt5gkuroUthmfWsfzHeuHF0Dy1Fzk/WuwDPHcFROgJRpm4eLD3xsHmX0Q z/TbMJYwTJkyFX8CkRD4YcjnCzgcNkJ/NPTldfzRML8n8aHriMbacUKdIiYMBQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f0vSm65n1z39b for ; Tue, 27 Jan 2026 18:44:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 200a3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 27 Jan 2026 18:44:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: bf60fb351df1 - stable/14 - ctld: Fail for missing or invalid CHAP secrets in UCL config List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: bf60fb351df14fc6b5161cc28c1f130d6484d8ba Auto-Submitted: auto-generated Date: Tue, 27 Jan 2026 18:44:08 +0000 Message-Id: <69790778.200a3.1be66cf3@gitrepo.freebsd.org> The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=bf60fb351df14fc6b5161cc28c1f130d6484d8ba commit bf60fb351df14fc6b5161cc28c1f130d6484d8ba Author: John Baldwin AuthorDate: 2025-02-12 19:27:06 +0000 Commit: John Baldwin CommitDate: 2026-01-27 18:15:56 +0000 ctld: Fail for missing or invalid CHAP secrets in UCL config Reviewed by: asomers Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D48931 (cherry picked from commit f42f7bedabb329b68c7c9aa0d9a2dc49637d385f) --- usr.sbin/ctld/uclparse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/usr.sbin/ctld/uclparse.c b/usr.sbin/ctld/uclparse.c index bd3c90283f6d..8654004d009e 100644 --- a/usr.sbin/ctld/uclparse.c +++ b/usr.sbin/ctld/uclparse.c @@ -73,6 +73,7 @@ uclparse_chap(struct auth_group *auth_group, const ucl_object_t *obj) if (!secret || secret->type != UCL_STRING) { log_warnx("chap section in auth-group \"%s\" is missing " "\"secret\" string key", auth_group->ag_name); + return (false); } ca = auth_new_chap(auth_group,