Skip site navigation (1)Skip section navigation (2) 
Date:      Sat, 05 Sep 2015 12:01:28 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 202905] [PATCH] audio/hydrogen: Add USES=libarchive, stop setting LDFLAGS.
Message-ID:  <bug-202905-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202905

            Bug ID: 202905
           Summary: [PATCH] audio/hydrogen: Add USES=libarchive, stop
                    setting LDFLAGS.
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: freebsd-ports-bugs@FreeBSD.org
          Reporter: rakuco@FreeBSD.org
                CC: FreeBSD@ShaneWare.Biz
            Blocks: 202516
             Flags: maintainer-feedback?(FreeBSD@ShaneWare.Biz)
                CC: FreeBSD@ShaneWare.Biz
          Keywords: patch

Created attachment 160740
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=160740&action=edit
Proposed patch

The attached patch has two parts:

1. Import a pull request I've just sent upstream that makes FindHelper.cmake
behave better and stop using pkg-config's output directly as include and
library paths. The consequence is that libraries like libarchive, libsndfile,
jack etc are now found with their full path and we can stop setting LDFLAGS in
Makefile.

2. Set USES=libarchive. Even though the port does not require any functionality
that is only present in libarchive from ports, explicitly depending on a
certain version makes things more consistent.
   Additionally, before this patch there would be no dependency on libarchive
from ports but since the linker was previously called like this:
       c++ ... -o hydrogen -L/usr/local/lib -larchive -lsndfile ...
   so the port would end up linking against libarchive from ports when it was
present (which is always, since devel/cmake depends on it). And with this patch
we have
       c++ ... -o hydrogen -larchive /usr/local/lib/libsndfile.so ...
   which does link against libarchive from base, but then fails `make
stage-qa', which expects all ports to link against ports libarchive.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-202905-13>