From owner-svn-src-stable-10@FreeBSD.ORG  Thu Oct  2 06:25:17 2014
Return-Path: <owner-svn-src-stable-10@FreeBSD.ORG>
Delivered-To: svn-src-stable-10@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 01BB1D9A;
 Thu,  2 Oct 2014 06:25:17 +0000 (UTC)
Received: from mail-ig0-x22c.google.com (mail-ig0-x22c.google.com
 [IPv6:2607:f8b0:4001:c05::22c])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A0494BCB;
 Thu,  2 Oct 2014 06:25:16 +0000 (UTC)
Received: by mail-ig0-f172.google.com with SMTP id r2so1413795igi.5
 for <multiple recipients>; Wed, 01 Oct 2014 23:25:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=Me6UIyK4/wTNux/jKnXhkavPJRnR6KM7gT4BTWTdTBk=;
 b=GV5o0ROjiR+qN3US+rtvxp/mWIhTpC8XAA7eO2dXm8UNaIUmFQQdRP6eYe+7ybVSIE
 25nfYOLyN4j3ZmTmxJc/2hmrvK38PN7lgz+Ge7vTMKcipz2s7iAfAAzsdw40WpYlWSZh
 nHJHb5u9CwpNJTDYVVKp2Tsi3Xyy6eQ2Q2I3Hi8E2bZv1FudEl/0CoZrKugtIzeRNLTY
 jrI1uJGFYWM5cmX63rAL21uVkGI1Rzp+IDznStKjGON6r/mXs8MmfQegpbqN/Px5oTs3
 bbtXqrOYIlXNf4efwcUi7Cyjcp0ffx/6kczlXupMr5LGqfl/RyhO7pTBFHEVSpCoBDdQ
 ttog==
MIME-Version: 1.0
X-Received: by 10.50.57.110 with SMTP id h14mr1681081igq.26.1412231115811;
 Wed, 01 Oct 2014 23:25:15 -0700 (PDT)
Received: by 10.50.227.42 with HTTP; Wed, 1 Oct 2014 23:25:15 -0700 (PDT)
In-Reply-To: <20141002061628.GO1275@hub.FreeBSD.org>
References: <201410011618.s91GIfR5071251@svn.freebsd.org>
 <20141002141656.Y1807@besplex.bde.org>
 <20141002061628.GO1275@hub.FreeBSD.org>
Date: Wed, 1 Oct 2014 23:25:15 -0700
Message-ID: <CAGHfRMCLO-i+FpmrTF6RzAPb1owECKG9Joh6cRZd9c8Cc0+JRw@mail.gmail.com>
Subject: Re: svn commit: r272372 - stable/10/bin/rm
From: NGie Cooper <yaneurabeya@gmail.com>
To: Glen Barber <gjb@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: svn-src-stable@freebsd.org,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 svn-src-stable-10@freebsd.org, Bruce Evans <brde@optusnet.com.au>
X-BeenThere: svn-src-stable-10@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for only the 10-stable src tree
 <svn-src-stable-10.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-stable-10>, 
 <mailto:svn-src-stable-10-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable-10/>
List-Post: <mailto:svn-src-stable-10@freebsd.org>
List-Help: <mailto:svn-src-stable-10-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-stable-10>, 
 <mailto:svn-src-stable-10-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Oct 2014 06:25:17 -0000

On Wed, Oct 1, 2014 at 11:16 PM, Glen Barber <gjb@freebsd.org> wrote:
> On Thu, Oct 02, 2014 at 02:56:05PM +1000, Bruce Evans wrote:
>> On Wed, 1 Oct 2014, Glen Barber wrote:
>>
>> >Log:
>> > MFC r268376 (imp):
>> >
>> >   rm -rf can fail sometimes with an error from fts_read. Make it
>> >   honor fflag to ignore fts_read errors, but stop deleting from
>> >   that directory because no further progress can be made.
>>
>> I asked for this to be backed out in -current.  It is not suitable for MFC.
>>
>
> It fixes an immediate issue that prevents high-concurrent make(1) jobs
> from stomping over each other.

The real problem is noted in this bug:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192490 ; the
SUBDIR_PARALLEL logic is executing multiple instances of the
clean/cleandir .PHONY targets.

I agree with bde@ that this commit is papering over a bigger problem,
but it's annoying enough and causes enough false positives that I
understand why gjb@ MFCed the commit imp@ did in head.

Thank you..