From owner-svn-src-head@FreeBSD.ORG Fri Jul 16 12:35:08 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C63821065674; Fri, 16 Jul 2010 12:35:08 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [IPv6:2001:4068:10::3]) by mx1.freebsd.org (Postfix) with ESMTP id 54EB48FC18; Fri, 16 Jul 2010 12:35:08 +0000 (UTC) Received: from localhost (amavis.fra.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 5107341C758; Fri, 16 Jul 2010 14:35:07 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([192.168.74.103]) by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id IYg88a3xHmRz; Fri, 16 Jul 2010 14:35:06 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id EA6AD41C74D; Fri, 16 Jul 2010 14:35:05 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 357BA4448EC; Fri, 16 Jul 2010 12:30:50 +0000 (UTC) Date: Fri, 16 Jul 2010 12:30:50 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Kostik Belousov In-Reply-To: <20100716080944.GA2381@deviant.kiev.zoral.com.ua> Message-ID: <20100716122932.S14969@maildrop.int.zabbadoz.net> References: <201007152024.o6FKObhM092035@svn.freebsd.org> <20100716064257.S14969@maildrop.int.zabbadoz.net> <20100716080944.GA2381@deviant.kiev.zoral.com.ua> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin Subject: Re: svn commit: r210138 - in head/sys: kern sys X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jul 2010 12:35:08 -0000 On Fri, 16 Jul 2010, Kostik Belousov wrote: > On Fri, Jul 16, 2010 at 06:44:39AM +0000, Bjoern A. Zeeb wrote: >> On Thu, 15 Jul 2010, John Baldwin wrote: >> >>> Author: jhb >>> Date: Thu Jul 15 20:24:37 2010 >>> New Revision: 210138 >>> URL: http://svn.freebsd.org/changeset/base/210138 >>> >>> Log: >>> Retire td_syscalls now that it is no longer needed. >>> >>> Modified: >>> head/sys/kern/kern_thread.c >>> head/sys/kern/subr_trap.c >>> head/sys/sys/proc.h >> >> Did you want to leave the field as a placehgolder or add a note >> somewhere that people should do a full recompile because the layout >> changed? > Make depend should do the magic, right ? right, I am more worried about (out of tree) modules. struct thread is basically everywhere with curthread and thread * passed around and modules will not refuse to load as freebsd_version hasn't changed. > I was surprised to see that mips/arm did not touched td_syscalls, and > I wonder how much other bugs are lurking in their implementation. >> >> >>> Modified: head/sys/sys/proc.h >>> ============================================================================== >>> --- head/sys/sys/proc.h Thu Jul 15 19:52:54 2010 (r210137) >>> +++ head/sys/sys/proc.h Thu Jul 15 20:24:37 2010 (r210138) >>> @@ -296,7 +296,6 @@ struct thread { >>> struct mdthread td_md; /* (k) Any machine-dependent fields. >>> */ >>> struct td_sched *td_sched; /* (*) Scheduler-specific data. */ >>> struct kaudit_record *td_ar; /* (k) Active audit record, if any. >>> */ >>> - int td_syscalls; /* per-thread syscall count (used by >>> NFS :)) */ >>> struct lpohead td_lprof[2]; /* (a) lock profiling objects. */ >>> struct kdtrace_thread *td_dtrace; /* (*) DTrace-specific data. */ >>> int td_errno; /* Error returned by last syscall. */ >>> >> >> -- >> Bjoern A. Zeeb From August on I will have a life. It's now up to you >> to do the maths and count to 64. -- Bondorf, Germany, 14th June 2010 > -- Bjoern A. Zeeb From August on I will have a life. It's now up to you to do the maths and count to 64. -- Bondorf, Germany, 14th June 2010