Date: Fri, 16 Jul 2010 12:30:50 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Kostik Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin <jhb@freebsd.org> Subject: Re: svn commit: r210138 - in head/sys: kern sys Message-ID: <20100716122932.S14969@maildrop.int.zabbadoz.net> In-Reply-To: <20100716080944.GA2381@deviant.kiev.zoral.com.ua> References: <201007152024.o6FKObhM092035@svn.freebsd.org> <20100716064257.S14969@maildrop.int.zabbadoz.net> <20100716080944.GA2381@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 16 Jul 2010, Kostik Belousov wrote: > On Fri, Jul 16, 2010 at 06:44:39AM +0000, Bjoern A. Zeeb wrote: >> On Thu, 15 Jul 2010, John Baldwin wrote: >> >>> Author: jhb >>> Date: Thu Jul 15 20:24:37 2010 >>> New Revision: 210138 >>> URL: http://svn.freebsd.org/changeset/base/210138 >>> >>> Log: >>> Retire td_syscalls now that it is no longer needed. >>> >>> Modified: >>> head/sys/kern/kern_thread.c >>> head/sys/kern/subr_trap.c >>> head/sys/sys/proc.h >> >> Did you want to leave the field as a placehgolder or add a note >> somewhere that people should do a full recompile because the layout >> changed? > Make depend should do the magic, right ? right, I am more worried about (out of tree) modules. struct thread is basically everywhere with curthread and thread * passed around and modules will not refuse to load as freebsd_version hasn't changed. > I was surprised to see that mips/arm did not touched td_syscalls, and > I wonder how much other bugs are lurking in their implementation. >> >> >>> Modified: head/sys/sys/proc.h >>> ============================================================================== >>> --- head/sys/sys/proc.h Thu Jul 15 19:52:54 2010 (r210137) >>> +++ head/sys/sys/proc.h Thu Jul 15 20:24:37 2010 (r210138) >>> @@ -296,7 +296,6 @@ struct thread { >>> struct mdthread td_md; /* (k) Any machine-dependent fields. >>> */ >>> struct td_sched *td_sched; /* (*) Scheduler-specific data. */ >>> struct kaudit_record *td_ar; /* (k) Active audit record, if any. >>> */ >>> - int td_syscalls; /* per-thread syscall count (used by >>> NFS :)) */ >>> struct lpohead td_lprof[2]; /* (a) lock profiling objects. */ >>> struct kdtrace_thread *td_dtrace; /* (*) DTrace-specific data. */ >>> int td_errno; /* Error returned by last syscall. */ >>> >> >> -- >> Bjoern A. Zeeb From August on I will have a life. It's now up to you >> to do the maths and count to 64. -- Bondorf, Germany, 14th June 2010 > -- Bjoern A. Zeeb From August on I will have a life. It's now up to you to do the maths and count to 64. -- Bondorf, Germany, 14th June 2010
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100716122932.S14969>