From nobody Sat Apr 11 10:32:09 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ft9396pF9z6YGNg for ; Sat, 11 Apr 2026 10:32:21 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ft9395hQQz3hVY for ; Sat, 11 Apr 2026 10:32:21 +0000 (UTC) (envelope-from lwhsu@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1775903541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+S582vAoRLW4CfplnCvGI9yyxA4JtHhKvNlP9gvgZ2Y=; b=je3Yg3kPu7GeYKZ8jEcoKEkDJvwi5IRYjibRRuAHGM9Yb4/FXRr49IdYfNa/NZWz0/t4eG 2x0zZiI7bq45TS08cd5vXPVuGJinyoe2hgkmAqgQFDDEhbLquWM7vYkay+J++m745GEnoj CKnTxbdBDoXnryHG4wRIYFA85NwACQ70LInXzNHc7aQzWk8PEqZJOLcjrT2P6Dfq6hlyTO rpGJFrmAccwwUONI4D2kXYtcrHOXN6rI886PvYJVj1RqbFAZgH0AThBIU1rpm7q70wv00o 6Jvwp6X5LEXoNbJIzr7D/0cYfwx8Yg12z99+v4jA0wRuVMNLMhMc5Knr5QdLGg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1775903541; a=rsa-sha256; cv=none; b=iu2Ov0CdWQA/ZtnryXNvHYvFbC/qqXK2RvaXLum+xEQkcukfwFsvwAkwWf9rNU6nB8QBLP iglgwKrC5rUxpzFJI5SUAjH+XyOYzOhksvmKT5bfZwQzC7viWo+IvHbcp4j6kLVbUMInKg 2wlT5f9oaqk0J3cDGvRSSho7vLpsooN05k4n50pUIm9AyJY9F1jr8g2oaTprejyCZInnvK N+SPOC+XVS4EZRTrkZrg/WdgNiS4wzzRwO1y7e9vWzFD8sZrtz0AFnK0g+D9BC0ipSbfs/ ITFZu51Mgtp+bMWme3LX7fxmBxl45DIggugOZf1VqjhUHqC7eUYKlm9JhbJcfA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1775903541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+S582vAoRLW4CfplnCvGI9yyxA4JtHhKvNlP9gvgZ2Y=; b=VdXkMOh6l4Phndf6L2fpqioFOoQHYYy5hOYdCkrrSkgCKhHRyDEUmuuEHguabImJtVmc0Y 7L5fyEMYPBZpFTvbcimOLva+PCgGeZ/Iciz0C1Tozwe25ph1xAANFzzKKAvrZnq9SbRboc cWu9r9TXfLcsi0GgVHngFMxWxw0vCricBFVRw0GFVh5qi64qVdSVq5wb6K0R+N8OCd9Ovq yi8I3CS5+bNjYg+SVs3thor+vpT/VRvkq2YjzzlIBUDnqCjzDlyff/DpJurUX4EA7pJne5 GiJ7LSBm2RUA8i1V81DHln4evZeHM76R9vfvj9PebhvcpQQh0jwDhb+L8q3NJg== Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: lwhsu/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ft93943lbznpJ for ; Sat, 11 Apr 2026 10:32:21 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-7dc3d28e2f3so273061a34.0 for ; Sat, 11 Apr 2026 03:32:21 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWSGAXHGZFkYBpSn1jmU30SUT+YsWu08mPBfWL/8iEOvEvxNtDsjnrO5XSKk1UWIqirfQbhMluQ4M3bC7SoeWq7S7vGKA==@freebsd.org X-Gm-Message-State: AOJu0Ywkak0RxknJLVZ4xjG/mmO6SbSj/FMpJ763hR+DdYWvvResCV1f EA7huq4FyJAv6LQWR5YnxqpOAn8vxOjGq4nqKIz1594v8FdnZGj4Yk4DDDXJnIawRvlILzGNOnS LE1dkxR+Ez9zSzIXCNWcKlPpEvMO+xKc= X-Received: by 2002:a05:6830:4aca:b0:7d7:c911:1829 with SMTP id 46e09a7af769-7dc27db8293mr4975429a34.16.1775903540731; Sat, 11 Apr 2026 03:32:20 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <69d6c795.18adf.7af84449@gitrepo.freebsd.org> <60q35572-pprr-op23-p392-266469oon60@mnoonqbm.arg> In-Reply-To: From: Li-Wen Hsu Date: Sat, 11 Apr 2026 18:32:09 +0800 X-Gmail-Original-Message-ID: X-Gm-Features: AQROBzDixB6CFcqlEnQ-BWYU2FdV2ZC6akt9INKYyxIKjfQRCQpvG1Zl-UDu9f0 Message-ID: Subject: Re: git: c0d9a07101a1 - main - MFV: zstd 1.5.7. To: Michael Tuexen Cc: Xin Li , Adrian Chadd , "Bjoern A. Zeeb" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000b365b8064f2cc32f" --000000000000b365b8064f2cc32f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Apr 11, 2026 at 3:25=E2=80=AFPM Michael Tuexen = wrote: > > On 11. Apr 2026, at 06:56, Xin Li wrote: > > > > On 2026-04-10 21:00, Adrian Chadd wrote: > >> hi! > >> Same; this is breaking on my Snapdragon X1E FDT BSP work. > >> It fails super early in kernel hand-off. It's going to be a pain to > >> figure out locally as I have a framebuffer and I'd have to go do all > >> the early mapping to do super early (in initarm()) framebuffer work. > >> Is this reproducible by anyone else? delphij@, do you have any arm64 > >> FDT devices? Or maybe QEMU? > > > > bz@ and lwhsu@ did some diagnostic work, and this should help (adding > -DZSTD_NO_TRACE to ZSTD_C) > > > > diff --git a/sys/conf/kern.pre.mk b/sys/conf/kern.pre.mk > > index 871cd1c0705a..043d3fd0927c 100644 > > --- a/sys/conf/kern.pre.mk > > +++ b/sys/conf/kern.pre.mk > > @@ -158,7 +158,7 @@ NORMAL_FWO=3D ${CC:N${CCACHE_BIN}} -c ${ASM_CFLAGS} > ${WERROR} -o ${.TARGET} \ > > NOSAN_C=3D ${NORMAL_C:N-fsanitize*:N-fno-sanitize*:N-fasan-shadow-offse= t*} > > > > # for ZSTD in the kernel (include zstd/lib/freebsd before other CFLAGS) > > -ZSTD_C=3D ${CC} -c -DZSTD_HEAPMODE=3D1 -I$S/contrib/zstd/lib/freebsd > ${CFLAGS} \ > > +ZSTD_C=3D ${CC} -c -DZSTD_NO_TRACE -DZSTD_HEAPMODE=3D1 > -I$S/contrib/zstd/lib/freebsd ${CFLAGS} \ > > -I$S/contrib/zstd/lib -I$S/contrib/zstd/lib/common ${WERROR} \ > > -Wno-missing-prototypes -U__BMI__ -DZSTD_NO_INTRINSICS ${.IMPSRC= } > > # https://github.com/facebook/zstd/commit/812e8f2a [zstd 1.4.1] > Should building a new kernel with this patch resolve the issue or > is a buildworld/installworld required? > > I tested building a new kernel with this patch and it does not resolve th= e > issue for me (VirtualBox VM on macOS and QEMU on Rasbian). I haven't tested this one, the original patch was adding: #define ZSTD_TRACE 0 to sys/contrib/zstd/lib/freebsd/zstd_kfreebsd.h This fixes my case running in QEMU. > Best regards > Michael > > > > > > > >> -adrian > >> On Thu, 9 Apr 2026 at 19:31, Bjoern A. Zeeb wrote: > >>> > >>> On Wed, 8 Apr 2026, Xin LI wrote: > >>> > >>>> The branch main has been updated by delphij: > >>>> > >>>> URL: > https://cgit.FreeBSD.org/src/commit/?id=3Dc0d9a07101a1e72769ee0619a583f63= a078fb391 > >>>> > >>>> commit c0d9a07101a1e72769ee0619a583f63a078fb391 > >>>> Merge: dd201e407e48 7e509d50854e > >>>> Author: Xin LI > >>>> AuthorDate: 2026-04-08 21:22:45 +0000 > >>>> Commit: Xin LI > >>>> CommitDate: 2026-04-08 21:22:45 +0000 > >>>> > >>>> MFV: zstd 1.5.7. > >>>> > >>>> MFC after: 2 weeks > >>>> Relnotes: yes > >>> > >>> I do not know how but this makes an arm64 machine, > >>> doing a UEFI netboot (in case it matters) fetching the > /boot/loader.efi, > >>> to fail. > >>> Kernel is the GENERIC-MMCCAM and I do not do ZFS, just to be sure. > >>> > >>> See this thread for a "bisect" and symptoms: > >>> https://lists.freebsd.org/archives/freebsd-arm/2026-April/005757.html > >>> > >>> /bz > >>> > >>> -- > >>> Bjoern A. Zeeb > r15:7 > >>> > > > > > > > --000000000000b365b8064f2cc32f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Apr 11, 2026 at 3:25=E2=80=AFPM M= ichael Tuexen <tuexen@freebsd.org<= /a>> wrote:
> On 11. Apr 2026, at 06:56,= Xin Li <delphi= j@freebsd.org> wrote:
>
> On 2026-04-10 21:00, Adrian Chadd wrote:
>> hi!
>> Same; this is breaking on my Snapdragon X1E FDT BSP work.
>> It fails super early in kernel hand-off. It's going to be a pa= in to
>> figure out locally as I have a framebuffer and I'd have to go = do all
>> the early mapping to do super early (in initarm()) framebuffer wor= k.
>> Is this reproducible by anyone else? delphij@, do you have any arm= 64
>> FDT devices? Or maybe QEMU?
>
> bz@ and lwhsu@ did some diagnostic work, and this should help (adding = -DZSTD_NO_TRACE to ZSTD_C)
>
> diff --git a/sys/conf/kern.pre.mk b/sys/conf/kern.pre.mk
> index 871cd1c0705a..043d3fd0927c 100644
> --- a/sys/conf/kern.pre.mk
> +++ b/sys/conf/kern.pre.mk
> @@ -158,7 +158,7 @@ NORMAL_FWO=3D ${CC:N${CCACHE_BIN}} -c ${ASM_CFLAGS= } ${WERROR} -o ${.TARGET} \
> NOSAN_C=3D ${NORMAL_C:N-fsanitize*:N-fno-sanitize*:N-fasan-shadow-offs= et*}
>
> # for ZSTD in the kernel (include zstd/lib/freebsd before other CFLAGS= )
> -ZSTD_C=3D ${CC} -c -DZSTD_HEAPMODE=3D1 -I$S/contrib/zstd/lib/freebsd = ${CFLAGS} \
> +ZSTD_C=3D ${CC} -c -DZSTD_NO_TRACE -DZSTD_HEAPMODE=3D1 -I$S/contrib/z= std/lib/freebsd ${CFLAGS} \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 -I$S/contrib/zstd/lib -I$S/contrib/zstd/lib= /common ${WERROR} \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 -Wno-missing-prototypes -U__BMI__ -DZSTD_NO= _INTRINSICS ${.IMPSRC}
> # https://github.com/facebook/zstd/commit/812e8= f2a [zstd 1.4.1]
Should building a new kernel with this patch resolve the issue or
is a buildworld/installworld required?

I tested building a new kernel with this patch and it does not resolve the<= br> issue for me (VirtualBox VM on macOS and QEMU on Rasbian).
I haven't tested this one, the original patch was addin= g:

#define ZSTD_TRACE 0

t= o

sys/contrib/zstd/lib/freebsd/zstd_kfreebsd.h

This fixes my case running in QEMU.
=C2=A0<= /div>
Best regards
Michael
>
>
>
>> -adrian
>> On Thu, 9 Apr 2026 at 19:31, Bjoern A. Zeeb <bz@freebsd.org> wrote:
>>>
>>> On Wed, 8 Apr 2026, Xin LI wrote:
>>>
>>>> The branch main has been updated by delphij:
>>>>
>>>> URL: https://cgit.FreeBSD.org/src/commit/?id=3Dc0d9a07101a1e72769ee0619a583f= 63a078fb391
>>>>
>>>> commit c0d9a07101a1e72769ee0619a583f63a078fb391
>>>> Merge: dd201e407e48 7e509d50854e
>>>> Author:=C2=A0 =C2=A0 =C2=A0Xin LI <delphij@FreeBSD.org&= gt;
>>>> AuthorDate: 2026-04-08 21:22:45 +0000
>>>> Commit:=C2=A0 =C2=A0 =C2=A0Xin LI <delphij@FreeBSD.org&= gt;
>>>> CommitDate: 2026-04-08 21:22:45 +0000
>>>>
>>>>=C2=A0 =C2=A0 MFV: zstd 1.5.7.
>>>>
>>>>=C2=A0 =C2=A0 MFC after:=C2=A0 =C2=A0 =C2=A0 2 weeks
>>>>=C2=A0 =C2=A0 Relnotes:=C2=A0 =C2=A0 =C2=A0 =C2=A0yes
>>>
>>> I do not know how but this makes an arm64 machine,
>>> doing a UEFI netboot (in case it matters) fetching the /boot/l= oader.efi,
>>> to fail.
>>> Kernel is the GENERIC-MMCCAM and I do not do ZFS, just to be s= ure.
>>>
>>> See this thread for a "bisect" and symptoms:
>>> https://lists.free= bsd.org/archives/freebsd-arm/2026-April/005757.html
>>>
>>> /bz
>>>
>>> --
>>> Bjoern A. Zeeb=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0r15:7
>>>
>
>


--000000000000b365b8064f2cc32f--