From owner-freebsd-stable@FreeBSD.ORG Tue Feb 17 22:23:38 2009 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 212C91065726 for ; Tue, 17 Feb 2009 22:23:38 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id E506C8FC22 for ; Tue, 17 Feb 2009 22:23:37 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (pool-98-109-39-197.nwrknj.fios.verizon.net [98.109.39.197]) by cyrus.watson.org (Postfix) with ESMTPSA id 8360D46B38; Tue, 17 Feb 2009 17:23:37 -0500 (EST) Received: from localhost (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.3/8.14.3) with ESMTP id n1HMNEkb037171; Tue, 17 Feb 2009 17:23:31 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Jens Rehsack Date: Tue, 17 Feb 2009 10:42:25 -0500 User-Agent: KMail/1.9.7 References: <4996C16D.8050909@web.de> In-Reply-To: <4996C16D.8050909@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200902171042.26151.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 17 Feb 2009 17:23:31 -0500 (EST) X-Virus-Scanned: ClamAV 0.94.2/8998/Mon Feb 16 22:40:00 2009 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00, DATE_IN_PAST_06_12 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: freebsd-stable@freebsd.org Subject: Re: Error compiling FreeBSD-Stable with MFC'ed iconv locking X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2009 22:23:38 -0000 On Saturday 14 February 2009 8:04:45 am Jens Rehsack wrote: > Hi John, > > after I updated my system (-STABLE) I received following compilation error > while building the kernel (having ICONV built in): > > cc -c -O2 -frename-registers -pipe -fno-strict-aliasing -march=nocona > -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes > -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef > -Wno-pointer-sign -fformat-extensions -nostdinc -I. -I/usr/src/sys > -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include > opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 > --param large-function-growth=1000 -fno-omit-frame-pointer -mcmodel=kernel > -mno-red-zone -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow > -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -Werror > /usr/src/sys/libkern/iconv.c > /usr/src/sys/libkern/iconv.c: In function 'iconv_mod_unload': > /usr/src/sys/libkern/iconv.c:92: error: 'curthread' undeclared (first use in > this function) > /usr/src/sys/libkern/iconv.c:92: error: (Each undeclared identifier is > reported only once > /usr/src/sys/libkern/iconv.c:92: error: for each function it appears in.) > /usr/src/sys/libkern/iconv.c: In function 'iconv_sysctl_add': > /usr/src/sys/libkern/iconv.c:401: error: 'curthread' undeclared (first use > in this function) > /usr/src/sys/libkern/iconv.c: In function 'iconv_converter_handler': > /usr/src/sys/libkern/iconv.c:452: error: 'curthread' undeclared (first use > in this function) > > I applied following patch - and it works: > --- sys/sys/sx.h.orig 2009-02-14 12:56:11.000000000 +0000 > +++ sys/sys/sx.h 2009-02-14 12:57:33.000000000 +0000 > @@ -35,6 +35,7 @@ > #include > #include > #include > +#include > > #ifdef _KERNEL > #include > > Google didn't find anything so I thought I mail this quickly. The most recent commit to to include in the _KERNEL section should fix this. -- John Baldwin