From owner-svn-src-all@freebsd.org Wed Oct 2 17:44:16 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AE29213528F; Wed, 2 Oct 2019 17:44:16 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46k3RN4BBrz3H1J; Wed, 2 Oct 2019 17:44:16 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from [172.17.133.228] (unknown [12.202.168.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id DE093CEFC; Wed, 2 Oct 2019 17:44:15 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/10.1d.0.190908 Date: Wed, 02 Oct 2019 10:44:12 -0700 Subject: Re: svn commit: r352925 - head/sys/dev/xen/control From: Ravi Pokala To: Roger Pau =?UTF-8?B?TW9ubsOp?= , Ravi Pokala CC: , , Message-ID: Thread-Topic: svn commit: r352925 - head/sys/dev/xen/control References: <201910010821.x918LfOg005983@repo.freebsd.org> <5E0C7E54-2657-4E70-8A18-84C4EE29D4FA@panasas.com> <20191002075302.caak27hnk5vlpqgr@Air-de-Roger> In-Reply-To: <20191002075302.caak27hnk5vlpqgr@Air-de-Roger> Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Oct 2019 17:44:16 -0000 =EF=BB=BF-----Original Message----- From: Roger Pau Monn=C3=A9 Date: 2019-10-02, Wednesday at 00:53 To: Ravi Pokala Cc: , , Subject: Re: svn commit: r352925 - head/sys/dev/xen/control On Tue, Oct 01, 2019 at 06:42:14PM -0700, Ravi Pokala wrote: > Hi Roger, >=20 > If I'm understanding this diff correctly, all of (poweroff, reboot, s= uspend) will use the common string "shutdown", rather than an event-specific= string. Is that what we want? =20 I think there's some misunderstanding here. All power control events use the same xenstore node (~/control/shutdown), but the command read from it is different depending on the requested action (poweroff, reboot, halt...). Ah! Yes indeed, that was a misunderstanding on my part. I thought "shutdown= " was the command text, rather than a component of the path containing the c= ommand. See [0] for a slightly more detailed description of the xenstore node. =20 Note that this commit doesn't change any of this logic, it just clears the contents of ~/control/shutdown (by writing "") so the toolstack knows FreeBSD has acknowledged the request and it's processing it. Yes, that all makes sense. Thanks for clarifying! -Ravi (rpokala@) Roger. =20 [0] http://xenbits.xen.org/docs/4.12-testing/misc/xenstore-paths.html#p= latform-feature-and-control-paths =20