Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 Aug 2018 10:16:09 -0700
From:      Yuri <yuri@rawbw.com>
To:        Kurt Jaeger <pi@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r477695 - in head/graphics: . libheif
Message-ID:  <b4a250d0-7fe5-5830-d1d0-d93f3736471f@rawbw.com>
In-Reply-To: <201808210024.w7L0OIQH031059@repo.freebsd.org>
References:  <201808210024.w7L0OIQH031059@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 8/20/18 5:24 PM, Kurt Jaeger wrote:
> +BROKEN_FreeBSD_10=	encoder_fuzzer.cc:84:5: error: use of undeclared identifier 'free'


This is most likely wrong. 'free' is available everywhere. The likely 
reason is a missing #include <stdlib.h> somewhere.


> +LIB_DEPENDS=		libde265.so:multimedia/libde265
> +LIB_DEPENDS+=		libx265.so:multimedia/x265
> +LIB_DEPENDS+=		libpng16.so:graphics/png


These are usually defined without repeating LIB_DEPENDS+=.


> +USES=			autoreconf libtool pkgconfig shared-mime-info \
> +			shebangfix
> +USE_GITHUB=		yes
> +GH_ACCOUNT=		strukturag
> +GH_PROJECT=		libheif
> +
> +GNU_CONFIGURE=		yes
> +
> +SHEBANG_GLOB=		*.sh
> +
> +USE_LDCONFIG=		yes

USE_LDCONFIG should definitely be in the USExx section. GNU_CONFIGURE and SHEBANG_GLOB should also probably be in USExx section, because this way Makefile looks more compact.


Yuri





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b4a250d0-7fe5-5830-d1d0-d93f3736471f>