From owner-cvs-src@FreeBSD.ORG  Mon Mar 20 00:13:48 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0193016A400;
	Mon, 20 Mar 2006 00:13:48 +0000 (UTC)
	(envelope-from csjp@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C764543D45;
	Mon, 20 Mar 2006 00:13:47 +0000 (GMT)
	(envelope-from csjp@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k2K0DlOJ042254;
	Mon, 20 Mar 2006 00:13:47 GMT
	(envelope-from csjp@repoman.freebsd.org)
Received: (from csjp@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k2K0Dl9U042253;
	Mon, 20 Mar 2006 00:13:47 GMT (envelope-from csjp)
Message-Id: <200603200013.k2K0Dl9U042253@repoman.freebsd.org>
From: "Christian S.J. Peron" <csjp@FreeBSD.org>
Date: Mon, 20 Mar 2006 00:13:47 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/kern kern_descrip.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Mar 2006 00:13:48 -0000

csjp        2006-03-20 00:13:47 UTC

  FreeBSD src repository

  Modified files:
    sys/kern             kern_descrip.c 
  Log:
  Restore fd optimization with a few minor tweaks, to quote tegge:
  
  "fdinit() fails to initialize newfdp->fd_fd.fd_lastfile to -1.  This breaks
  fdcopy() which will incorrectly set newfdp->fd_freefile to 1 if no files are
  open and the last file descriptor marked as unused for fdp was 0.  This later
  causes descriptor 0 to be unavailable in newfdp when the optimization is
  enabled.
  
  When the last file descriptor previously marked as used is nonzero and marked
  as unused, fdunused() incorrectly sets fdp->fd_lastfile to fd - 1 due to
  fd_last_used() returning (size - 1).  This hides the problem that breaks the
  optimization."
  
  This allows us to keep the optimization, while un-breaking it.
  
  This is a RELENG_6 candidate.
  
  PR:             kern/87208
  MFC after:      1 week
  Submitted by:   tegge
  
  Revision  Changes    Path
  1.293     +5 -2      src/sys/kern/kern_descrip.c