From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Jul 13 12:40:02 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3BEBB106567E for ; Sun, 13 Jul 2008 12:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 1375D8FC15 for ; Sun, 13 Jul 2008 12:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m6DCe1KQ057512 for ; Sun, 13 Jul 2008 12:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m6DCe113057511; Sun, 13 Jul 2008 12:40:01 GMT (envelope-from gnats) Resent-Date: Sun, 13 Jul 2008 12:40:01 GMT Resent-Message-Id: <200807131240.m6DCe113057511@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jan Henrik Sylvester Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2215810656BF for ; Sun, 13 Jul 2008 12:36:06 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 0C0488FC0A for ; Sun, 13 Jul 2008 12:36:06 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m6DCa5EG094497 for ; Sun, 13 Jul 2008 12:36:05 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m6DCa5ux094496; Sun, 13 Jul 2008 12:36:05 GMT (envelope-from nobody) Message-Id: <200807131236.m6DCa5ux094496@www.freebsd.org> Date: Sun, 13 Jul 2008 12:36:05 GMT From: Jan Henrik Sylvester To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/125564: sysutils/testdisk configure picks up libs as installed X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jul 2008 12:40:02 -0000 >Number: 125564 >Category: ports >Synopsis: sysutils/testdisk configure picks up libs as installed >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Jul 13 12:40:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Jan Henrik Sylvester >Release: FreeBSD 7.0-RELEASE-p2 i386 >Organization: >Environment: >Description: sysutils/testdisk configure picks up optional dependencies if installed => add '.else CONFIGURE_ARGS+=--without-*' to '.if defined(WITH_*)' configure picks up iconv if present => add WITH_ICONV OPTION e2fsprogs does not currently provide ext2fs.so, since it does not do 'make install-libs' => comment out WITH_E2FSPROGS for now (or change e2fsprogs port) >How-To-Repeat: - install sysutils/testdisk with libiconv present - install sysutils/testdisk with ntfsprogs present but disabled in OPTIONS - try to install sysutils/testdisk WITH_E2FSPROGS >Fix: - add WITH_ICONV to OPTIONS - for disabled OPTIONS, add CONFIGURE_ARGS+=--without-* - remove WITH_E2FSPROGS (as long as e2fsprogs does not provide ext2fs.so) Patch attached with submission follows: diff -urN Makefile.orig Makefile --- Makefile.orig 2008-02-14 14:23:29.000000000 +0100 +++ Makefile 2008-07-13 13:46:42.000000000 +0200 @@ -25,22 +25,37 @@ PLIST_FILES= sbin/testdisk sbin/photorec PORTDOCS= * -OPTIONS= E2FSPROGS "Use ext2fs extensions" off \ +OPTIONS= ICONV "Use iconv extensions" on \ NTFSPROGS "Use ntfs extensions" off \ PROGSREISERFS "Use reiserfs extensions" off +# E2FSPROGS "Use ext2fs extensions" off .include -.if defined(WITH_E2FSPROGS) -LIB_DEPENDS+= ext2fs.2:${PORTSDIR}/sysutils/e2fsprogs +.if defined(WITH_ICONV) +LIB_DEPENDS+= iconv.3:${PORTSDIR}/converters/libiconv +.else +CONFIGURE_ARGS+=--without-iconv .endif +# e2fsprogs does not provide ext2fs.so any more +# since it does not do 'make install-libs' +#.if defined(WITH_E2FSPROGS) +#LIB_DEPENDS+= ext2fs.2:${PORTSDIR}/sysutils/e2fsprogs +#.else +#CONFIGURE_ARGS+=--without-ext2fs +#.endif + .if defined(WITH_NTFSPROGS) LIB_DEPENDS+= ntfs.9:${PORTSDIR}/sysutils/ntfsprogs +.else +CONFIGURE_ARGS+=--without-ntfs .endif .if defined(WITH_PROGSREISERFS) LIB_DEPENDS+= reiserfs-0.3.0:${PORTSDIR}/sysutils/progsreiserfs +.else +CONFIGURE_ARGS+=--without-reiserfs .endif post-patch: >Release-Note: >Audit-Trail: >Unformatted: