From owner-cvs-all  Sat Jan  6 15:38:34 2001
From owner-cvs-all@FreeBSD.ORG  Sat Jan  6 15:38:30 2001
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from VL-MS-MR001.sc1.videotron.ca (relais.videotron.ca [24.201.245.36])
	by hub.freebsd.org (Postfix) with ESMTP
	id D53A437B400; Sat,  6 Jan 2001 15:38:29 -0800 (PST)
Received: from jehovah ([24.202.203.37]) by
          VL-MS-MR001.sc1.videotron.ca (Netscape Messaging Server 4.15)
          with SMTP id G6RLO500.QZ6; Sat, 6 Jan 2001 18:38:29 -0500 
Message-ID: <009201c07839$f29a2070$25cbca18@jehovah>
From: "Bosko Milekic" <bmilekic@technokratis.com>
To: "Alfred Perlstein" <bright@wintelcom.net>,
	"Poul-Henning Kamp" <phk@critter.freebsd.dk>
Cc: "Bosko Milekic" <bmilekic@FreeBSD.org>,
	<cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org>
References: <20010106132943.E15744@fw.wintelcom.net> <12666.978817510@critter> <20010106141257.F15744@fw.wintelcom.net>
Subject: Re: cvs commit: src/sys/dev/musycc musycc.c
Date: Sat, 6 Jan 2001 18:39:44 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 5.00.2919.6700
X-MimeOLE: Produced By Microsoft MimeOLE V5.00.2919.6700
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG


Alfred wrote:

> * Poul-Henning Kamp <phk@critter.freebsd.dk> [010106 13:45] wrote:
> > In message <20010106132943.E15744@fw.wintelcom.net>, Alfred Perlstein
writes:
> > >* Bosko Milekic <bmilekic@FreeBSD.org> [010106 12:44] wrote:
> > >> bmilekic    2001/01/06 12:44:40 PST
> > >>
> > >>   Modified files:
> > >>     sys/dev/musycc       musycc.c
> > >
> > >Grr, This isn't how it was supposed to be done.  Would you mind terribly
> > >if I cleaned it up to what I intended it to be:
> >
> >
> >
> > >! if ((m->m_flags M_EXT) == 0) {
> >
> > How is this supposed to compile in either of the committed or proposed
> > versions ?
>
> How the hell should I know? :)
>
> not only that but we have one of my favorite bugs:
>
>     while (csc->state != C_RUNNING)
>         tsleep(&csc->state, PZERO + PCATCH, "crun", hz/10);
>
> should have no PCATCH, or somehow deal with the signal instead of
> looping forever.
>
> You're right, this file is pretty broken. :)
>
> --
> -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org]
> "I have the heart of a child; I keep it in a jar on my desk."

This was my stupid typo mistake. It's fixed now. Thanks for pointing it out
and sorry about that.




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message