From owner-freebsd-current@freebsd.org Mon Jul 9 14:19:19 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7FB71102A246 for ; Mon, 9 Jul 2018 14:19:19 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 162AB71A6A for ; Mon, 9 Jul 2018 14:19:19 +0000 (UTC) (envelope-from ian@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id CA37F102A21A; Mon, 9 Jul 2018 14:19:18 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B6125102A219 for ; Mon, 9 Jul 2018 14:19:18 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 39EF171A69 for ; Mon, 9 Jul 2018 14:19:18 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-RoutePath: aGlwcGll X-MHO-User: 0a729390-8383-11e8-b829-b3adae557cda X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound2.ore.mailhop.org (Halon) with ESMTPSA id 0a729390-8383-11e8-b829-b3adae557cda; Mon, 09 Jul 2018 14:19:09 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w69EJ5uM033553; Mon, 9 Jul 2018 08:19:07 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1531145945.1336.23.camel@freebsd.org> Subject: Re: sys/Makefile .if defined(MODULES_WITH_WORLD) From: Ian Lepore To: "Julian H. Stacey" , current@freebsd.org Date: Mon, 09 Jul 2018 08:19:05 -0600 In-Reply-To: <201807090950.w699o1jF022468@fire.js.berklix.net> References: <201807090950.w699o1jF022468@fire.js.berklix.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2018 14:19:19 -0000 On Mon, 2018-07-09 at 11:50 +0200, Julian H. Stacey wrote: > Hi current@ > src/sys/dev/amdsbwd/amdsbwd.c broke src/sys/modules > > Is it immediately intuitive & well known to developers working in > sys/dev > to enable MODULES_WITH_WORLD before a test make all before a commit ? > > Or what should we do to increase the liklehood of commiters catching > modules/ errors before a commit ? > > With src/ > .ctm_status src-cur 13573 > .svn_revision 335362 > sys/Makefile has > .if defined(MODULES_WITH_WORLD) > SUBDIR+=modules > & nothing from cd /usr/src; find . -name \*src.conf\* > & no default /etc/src.conf with no > MODULES_WITH_WORLD=YES > so make all does not build /sys/modules/  > so this not seen from /sys/modules/ > ===> amdsbwd (all) > cc  -O2 -pipe -DBERKLIX=YES  -fno-strict-aliasing -Werror -D_KERNEL > -DKLD_MODULE -nostdinc   -I. -I/data/release/s1/usr/src/sys > -I/data/release/s1/usr/src/sys/contrib/ck/include -fno-common  -fno- > omit-frame-pointer -mno-omit-leaf-frame-pointer   -MD  - > MF.depend.amdsbwd.o -MTamdsbwd.o -mcmodel=kernel -mno-red-zone -mno- > mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables > -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls > -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer- > arith -Wcast-qual -Wundef -Wno-pointer-sign > -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs > -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error- > tautological-compare -Wno-error-empty-body -Wno-error-parentheses- > equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno- > error-shift-negative-value -Wno-address-of-packed-member  -mno-aes > -mno-avx  -std=iso9899:1999 -c > /data/release/s1/usr/src/sys/dev/amdsbwd/amdsbwd.c -o amdsbwd.o > /data/release/s1/usr/src/sys/dev/amdsbwd/amdsbwd.c:52:10: fatal > error:  >       'opt_amdsbwd.h' file not found > #include "opt_amdsbwd.h" > > > PS With  > .ctm_status src-cur 13601 > .svn_revision 336117 > nothing from > find . -name opt_amdsbwd.h > but this has > src/sys/dev/amdsbwd/amdsbwd.c > #include "opt_amdsbwd.h" > I haven't yet upgraded my src/ yet to see if it still fails. > > Cheers, > Julian Should be fixed in r336134. -- Ian