From owner-freebsd-hackers Tue Oct 23 11: 5:36 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from h132-197-97-45.gte.com (h132-197-179-27.gte.com [132.197.179.27]) by hub.freebsd.org (Postfix) with ESMTP id 473A537B403; Tue, 23 Oct 2001 11:05:31 -0700 (PDT) Received: (from ak03@localhost) by h132-197-97-45.gte.com (8.11.6/8.11.4) id f9NI5UN32243; Tue, 23 Oct 2001 14:05:30 -0400 (EDT) (envelope-from ak03) Message-ID: X-Mailer: XFMail 1.5.1 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Tue, 23 Oct 2001 14:05:29 -0400 (EDT) Organization: Verizon Laboratories Inc. From: "Alexander N. Kabaev" To: John Baldwin Subject: RE: sx_assert() vs. SX_ASSERT_*() Cc: hackers@FreeBSD.ORG Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG I am strongly suport the change :) I had to implement similar function for an unnamed product port for FreeBSD and your changes will definitely minimize my diffs. On 23-Oct-2001 John Baldwin wrote: > Anyone object greatly to making a change to the sx(9) API to use an > sx_assert() > function similar to mtx_assert() for mutexes instead of having > several > SX_ASSERT_FOO macros? > > Here is what the new API would look like: > > sx_assert(&foo_lock, SX_LOCKED); > sx_assert(&bar_lock, SX_SLOCKED); > > vs. > > SX_ASSERT_LOCKED(&foo_lock); > SX_ASSERT_SLOCKED(&bar_lock); > > -- > > John Baldwin -- http://www.FreeBSD.org/~jhb/ > PGP Key: http://www.baldwin.cx/~john/pgpkey.asc > "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-hackers" in the body of the message -------------------------------------------- E-Mail: Alexander N. Kabaev Date: 23-Oct-2001 Time: 14:00:00 -------------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message