From owner-cvs-all@FreeBSD.ORG Wed Dec 13 04:30:06 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8975716A407 for ; Wed, 13 Dec 2006 04:30:06 +0000 (UTC) (envelope-from rizzo@icir.org) Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 79AD843CA1 for ; Wed, 13 Dec 2006 04:28:39 +0000 (GMT) (envelope-from rizzo@icir.org) Received: from xorpc.icir.org (localhost [127.0.0.1]) by xorpc.icir.org (8.12.11/8.13.6) with ESMTP id kBD4U2He051919; Tue, 12 Dec 2006 20:30:02 -0800 (PST) (envelope-from rizzo@xorpc.icir.org) Received: (from rizzo@localhost) by xorpc.icir.org (8.12.11/8.12.3/Submit) id kBD4U2va051918; Tue, 12 Dec 2006 20:30:02 -0800 (PST) (envelope-from rizzo) Date: Tue, 12 Dec 2006 20:30:02 -0800 From: Luigi Rizzo To: "M. Warner Losh" Message-ID: <20061212203002.A51749@xorpc.icir.org> References: <20061212062445.A61903@xorpc.icir.org> <20061212183825.GF781@funkthat.com> <20061212.140133.1649770385.imp@bsdimp.com> <20061212.211323.-1573945956.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20061212.211323.-1573945956.imp@bsdimp.com>; from imp@bsdimp.com on Tue, Dec 12, 2006 at 09:13:23PM -0700 Cc: gurney_j@resnet.uoregon.edu, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, luigi@FreeBSD.org, cvs-all@FreeBSD.org, ticso@cicely.de Subject: Re: cvs commit: src/sys/net if_ethersubr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2006 04:30:06 -0000 On Tue, Dec 12, 2006 at 09:13:23PM -0700, M. Warner Losh wrote: > In message: <20061212.140133.1649770385.imp@bsdimp.com> ... > : while established practice in NetBSD, met with considerable > : controversy when I tried to expand it in FreeBSD land. However, > : putting things in param.h met with no resistance whatsoever and was > : actively suggested. Maybe we should move this straggler from _types.h > : to param.h and start using it more often. > : > : Warner > : > > Here's what I came up with this afternoon between fires at work. > > Comments? makes sense - there are probably more places where it should be used (judging by the output of "grep -r __sparc64__ sys/") just to make sure - are we guaranteed that param.h is included by every kernel file, or there is the risk that someone forgets it thus missing the #define __NO_STRICT_ALIGNMENT ? cheers luigi