From owner-svn-src-all@FreeBSD.ORG Thu Jan 6 22:54:50 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0B92B106566B; Thu, 6 Jan 2011 22:54:50 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id EEA7D8FC12; Thu, 6 Jan 2011 22:54:49 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id p06MsnkA031417; Thu, 6 Jan 2011 22:54:49 GMT (envelope-from cperciva@svn.freebsd.org) Received: (from cperciva@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id p06MsnPE031416; Thu, 6 Jan 2011 22:54:49 GMT (envelope-from cperciva@svn.freebsd.org) Message-Id: <201101062254.p06MsnPE031416@svn.freebsd.org> From: Colin Percival Date: Thu, 6 Jan 2011 22:54:49 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-releng@freebsd.org X-SVN-Group: releng MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r217082 - releng/8.2/sys/dev/xen/console X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jan 2011 22:54:50 -0000 Author: cperciva Date: Thu Jan 6 22:54:48 2011 New Revision: 217082 URL: http://svn.freebsd.org/changeset/base/217082 Log: MFS r217053: Fix the Xen console to not spew \0 bytes when there is no input available. Approved by: re (rwatson) Modified: releng/8.2/sys/dev/xen/console/console.c Directory Properties: releng/8.2/sys/ (props changed) releng/8.2/sys/amd64/include/xen/ (props changed) releng/8.2/sys/cddl/contrib/opensolaris/ (props changed) releng/8.2/sys/contrib/dev/acpica/ (props changed) releng/8.2/sys/contrib/pf/ (props changed) Modified: releng/8.2/sys/dev/xen/console/console.c ============================================================================== --- releng/8.2/sys/dev/xen/console/console.c Thu Jan 6 22:53:55 2011 (r217081) +++ releng/8.2/sys/dev/xen/console/console.c Thu Jan 6 22:54:48 2011 (r217082) @@ -145,17 +145,18 @@ xccngetc(struct consdev *dev) int xccncheckc(struct consdev *dev) { - int ret = (xc_mute ? 0 : -1); + int ret; if (xencons_has_input()) xencons_handle_input(NULL); CN_LOCK(cn_mtx); - if ((rp - rc)) { + if ((rp - rc) && !xc_mute) { /* we need to return only one char */ ret = (int)rbuf[RBUF_MASK(rc)]; rc++; - } + } else + ret = -1; CN_UNLOCK(cn_mtx); return(ret); }