From owner-cvs-all  Fri Sep 18 06:23:16 1998
Return-Path: <owner-cvs-all>
Received: (from daemon@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id GAA24491
          for cvs-all-outgoing; Fri, 18 Sep 1998 06:23:16 -0700 (PDT)
          (envelope-from owner-cvs-all)
Received: from labinfo.iet.unipi.it (labinfo.iet.unipi.it [131.114.9.5])
          by hub.freebsd.org (8.8.8/8.8.8) with SMTP id GAA24483;
          Fri, 18 Sep 1998 06:23:04 -0700 (PDT)
          (envelope-from luigi@labinfo.iet.unipi.it)
Received: from localhost (luigi@localhost) by labinfo.iet.unipi.it (8.6.5/8.6.5) id NAA26299; Fri, 18 Sep 1998 13:32:03 +0200
From: Luigi Rizzo <luigi@labinfo.iet.unipi.it>
Message-Id: <199809181132.NAA26299@labinfo.iet.unipi.it>
Subject: Re: cvs commit: src/sbin/ipfw ipfw.c src/sys/conf files src/sys/i386/isa if_ed.c if_ep.c if_lnc.c src/sys/net if_ethersubr.c src
To: eivind@yes.no (Eivind Eklund)
Date: Fri, 18 Sep 1998 13:32:03 +0200 (MET DST)
Cc: luigi@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
In-Reply-To: <19980918133152.09027@follo.net> from "Eivind Eklund" at Sep 18, 98 01:31:33 pm
X-Mailer: ELM [version 2.4 PL23]
Content-Type: text
Sender: owner-cvs-all@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> This commit is against the guidelines - you are not supposed to commit
> changes that break binary compatibility to -stable.
> 
> Also, you are not supposed to commit changes to -stable without having
> them 'mature' in -current first, unless they are security/doc fixes.
> 
> (Don't take these comments too negatively - I _love_ the functionality
> of dummynet :-)

i have asked permission to Jordan and Garret on these specific issues.

About the ipfw binary compatibility my apologies because i forgot
to mention that explicitly to the reviewers (and yes, now i remember
you pointed that out), but the change it was absolutely necessary
to have dummynet working.

In my partial defense:

  * the change only affects one binary, ipfw, and there is no user
    interface change (i.e. you still have 10 ports available in a rule)

  * even if you don't use dummynet, you get the SKIPTO optimization
    which should make ipfw usage more efficient.

	cheers
	luigi