Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Apr 2013 13:13:46 -0500
From:      Jan Beich <jbeich@tormail.org>
To:        Matthias Apitz <guru@unixarea.de>
Cc:        gecko@freebsd.org, freebsd-ports@freebsd.org
Subject:   Re: www/firefox (r315793, 20.0.1) does not compile
Message-ID:  <1UR4wA-000Fut-76@internal.tormail.org>
In-Reply-To: <20130413173629.GA2627__22839.3189413056$1365874613$gmane$org@tinyCurrent> (Matthias Apitz's message of "Sat, 13 Apr 2013 19:36:29 %2B0200")
References:  <20130413142647.GA2196@tinyCurrent> <51698370.5000107@smeets.im> <20130413173629.GA2627__22839.3189413056$1365874613$gmane$org@tinyCurrent>

next in thread | previous in thread | raw e-mail | index | archive | help
Matthias Apitz <guru@unixarea.de> writes:

> # uname -a
> FreeBSD aurora.Sisis.de 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r235646: Sat May 19 15:52:36 CEST 2012 guru@aurora.Sisis.de:/usr/obj/usr/src/sys/GENERIC  i386
>

At that time jemalloc 3.0.0 was imported, expect regressions.

/head had recently imported clang 3.3 so www/firefox may have compile
and runtime regressions. Be prepared or add USE_GCC=yes to Makefile.local.

> # diff -c work/mozilla-release/memory/mozalloc/mozalloc.cpp*
> *** work/mozilla-release/memory/mozalloc/mozalloc.cpp   Sat Apr 13
> 16:32:42 2013
> --- work/mozilla-release/memory/mozalloc/mozalloc.cpp.orig      Tue Mar
> 26 23:17:58 2013
> ***************
> *** 211,217 ****
>   #if defined(XP_MACOSX)
>       return malloc_size(ptr);
>   #elif defined(HAVE_MALLOC_USABLE_SIZE) || defined(MOZ_MEMORY)
> !     return moz_malloc_usable_size(ptr);
>   #elif defined(XP_WIN)
>       return _msize(ptr);
>   #else
> --- 211,217 ----
>   #if defined(XP_MACOSX)
>       return malloc_size(ptr);
>   #elif defined(HAVE_MALLOC_USABLE_SIZE) || defined(MOZ_MEMORY)
> !     return malloc_usable_size(ptr);
>   #elif defined(XP_WIN)
>       return _msize(ptr);
>   #else

Are you trying to make the function recursive? malloc_usable_size() is
part of libc since 7.0R when phkmalloc was replaced by jemalloc.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1UR4wA-000Fut-76>