From owner-svn-src-all@freebsd.org Thu Dec 20 19:54:08 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2A3B3135230A for ; Thu, 20 Dec 2018 19:54:08 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 987436A9E6 for ; Thu, 20 Dec 2018 19:54:07 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1545335611; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=fJHhd1Zl3QIlht8qpEtx5QyJY650SJkAmxwO4LN9IRC9L353+XzMVYnrVpyMzL88/jiBzdWu45w/Q kaWErtSQYW0a8kaup9gw2CbYzTd2JjIkES6Itjt4AmWvgX7n2B1cWP8zREMXlT4G5RwLJVpSqf1HL1 Fui4CmOg/NnxeU+H/k0YlBtflx7hpA48YI1uHDSsrMbLsd24NZDlHwRnz+B6tYp8tYHnTU0z4SOj3Z rID8f4phkq8lw/2miby7Izh4+2Jq7WWzmzTyWTsn+nYRLGeBJdEFGElI/fOT9vgvCogDP1xbi3zUDs p2FAwxoAMEdVDzP8pY8JViDnhUpwWnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=Co+k3QcBmeZBbi6rRA9xStFyVq0Y26GZ6LXQ7HzLd/0=; b=E5qfxQTtR2HB4zTa36SLR1ASPfsIozE4wh8FTyFCSVb+f53n2L125YQF2ccAXRhBs07Q8iQ+RuNdF mOsvQ+K269Qf6YfTSs9mY2fZbz4QCl1r/VOmJBc1u0aeaT8FejQsYFm+GwN6DJVA/suG9jCC/b+8mG +0QcDpkhLiYRMm1mrV2doZupnQLv0SPhPxd0Mofwu0ET2xBtrdfc+8lSUHdWzA9psyslP8Y2b/l4yJ rmbMzIhWrEEUuH2xFugLMtitlMqBiFMeRdJjiNGWbvquhd4blKuAMt+G6W27kBpaeKdy7Jzd7YTQkr /o1+dAqFP8QTDjvGeoK12q1/JJdyUBQ== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=Co+k3QcBmeZBbi6rRA9xStFyVq0Y26GZ6LXQ7HzLd/0=; b=Xu0wNT3/iL2etVyjuGhwdBYZEI3h+RYmj912Bs7ihkFyahMAEEhpvAIAlUozohFyF0hmaE0ImAAO7 iaP0X8NgA048Hiyda2mCDN5UBVqS31aaBdibwGed5ype+Vd29fzgLCPThoCY2LOk63oLAaQOBNG9Zy c1ssKcnetJ05uXuolZUXbtb2By/Z0VV7jA+dbFIikHfaZLwnztVF/sCamSLtkIxl43PEq55pSjICVg /3hq+i2iWJQTYSe9YodPd+Cs4x0hMthIt/5rWNEjuExhM+w1YjWEYx/PSTT1Td6LKedqHVFi8yNmjU L0ylx9XMjPUUM+Hudsi1mIreMBTvOWg== X-MHO-RoutePath: aGlwcGll X-MHO-User: ebcb2ebf-0490-11e9-a59a-7b143e15dabc X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id ebcb2ebf-0490-11e9-a59a-7b143e15dabc; Thu, 20 Dec 2018 19:53:29 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id wBKJrvGN001142; Thu, 20 Dec 2018 12:53:57 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1545335637.87734.36.camel@freebsd.org> Subject: Re: svn commit: r342283 - in head: release/amd64 release/arm64 release/i386 release/tools share/man/man8 tools/boot tools/tools/nanobsd/embedded usr.sbin/bsdinstall/partedit usr.sbin/bsdinstall/scripts From: Ian Lepore To: Shawn Webb , Rebecca Cran Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Thu, 20 Dec 2018 12:53:57 -0700 In-Reply-To: <20181220194941.wikdor2wnsr56g4n@mutt-hbsd> References: <201812201939.wBKJdbhB015092@repo.freebsd.org> <20181220194941.wikdor2wnsr56g4n@mutt-hbsd> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 987436A9E6 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.993,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 19:54:08 -0000 On Thu, 2018-12-20 at 14:49 -0500, Shawn Webb wrote: > On Thu, Dec 20, 2018 at 07:39:37PM +0000, Rebecca Cran wrote: > > > > Author: bcran > > Date: Thu Dec 20 19:39:37 2018 > > New Revision: 342283 > > URL: https://svnweb.freebsd.org/changeset/base/342283 > > > > Log: > >   Rework UEFI ESP generation > >    > >   Currently, the installer uses pre-created 800KB FAT12 filesystems > > that > >   it dd's onto the ESP partition. > >   This changeset improves that by having the installer generate a > > FAT32 > >   filesystem directly onto the ESP using newfs_msdos and then > > copying > >   loader.efi into /EFI/freebsd. > >   For live installs it then runs efibootmgr to add a FreeBSD boot > > entry > >   in the BIOS. > >    > >   Sponsored by: Netflix > >   Differential Revision: https://reviews.freebsd.org/D17947 > > > > Modified: > >   head/release/amd64/make-memstick.sh > >   head/release/amd64/mkisoimages.sh > >   head/release/arm64/make-memstick.sh > >   head/release/i386/make-memstick.sh > >   head/release/tools/vmimage.subr > >   head/share/man/man8/uefi.8 > >   head/tools/boot/install-boot.sh > >   head/tools/boot/rootgen.sh > >   head/tools/tools/nanobsd/embedded/common > >   head/usr.sbin/bsdinstall/partedit/gpart_ops.c > >   head/usr.sbin/bsdinstall/partedit/partedit_arm64.c > >   head/usr.sbin/bsdinstall/partedit/partedit_x86.c > >   head/usr.sbin/bsdinstall/scripts/bootconfig > >   head/usr.sbin/bsdinstall/scripts/zfsboot > > > > Modified: head/release/amd64/make-memstick.sh > > =================================================================== > > =========== > > --- head/release/amd64/make-memstick.sh Thu Dec 20 19:27:46 > > 2018 (r342282) > > +++ head/release/amd64/make-memstick.sh Thu Dec 20 19:39:37 > > 2018 (r342283) > > @@ -12,6 +12,9 @@ > >   > >  set -e > >   > > +scriptdir=$(dirname $(realpath $0)) > > +. ${scriptdir}/../../tools/boot/install-boot.sh > > + > >  PATH=/bin:/usr/bin:/sbin:/usr/sbin > >  export PATH > >   > > @@ -36,11 +39,16 @@ makefs -B little -o label=FreeBSD_Install -o > > version=2 > >  rm ${1}/etc/fstab > >  rm ${1}/etc/rc.conf.local > >   > > +# Make an ESP in a file. > > +espfilename=$(mktemp /tmp/efiboot.XXXXXX) > > +make_esp_file ${espfilename} ${fat32min} ${1}/boot/loader.efi > Hey Rebecca, > > Are there any other bits of the build process that touch files > outside > of ${MAKEOBJDIRPREFIX}? Clang puts its temp files in whatever directory TMPDIR is set to (typically /tmp). -- Ian