From owner-svn-ports-all@freebsd.org Tue Jul 5 20:47:30 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DE52DB71DB9 for ; Tue, 5 Jul 2016 20:47:30 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9DE6D18CF for ; Tue, 5 Jul 2016 20:47:30 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: a270cfb3-42f1-11e6-8929-8ded99d5e9d7 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.34.117.227 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.34.117.227]) by outbound2.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Tue, 5 Jul 2016 20:47:05 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.14.9) with ESMTP id u65KkJEF011717; Tue, 5 Jul 2016 14:46:20 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1467751579.72182.101.camel@freebsd.org> Subject: Re: svn commit: r418108 - head/net/openntpd From: Ian Lepore To: Adam Weinberger , Christian Weisgerber Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Date: Tue, 05 Jul 2016 14:46:19 -0600 In-Reply-To: References: <201607051932.u65JWH1S024239@repo.freebsd.org> Content-Type: text/plain; charset="iso-8859-13" X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2016 20:47:31 -0000 On Tue, 2016-07-05 at 13:37 -0600, Adam Weinberger wrote: > > On 5 Jul, 2016, at 13:32, Christian Weisgerber > > wrote: > > > > Author: naddy > > Date: Tue Jul 5 19:32:17 2016 > > New Revision: 418108 > > URL: https://svnweb.freebsd.org/changeset/ports/418108 > > > > Log: > > Minor changes/improvements: > > * switch to USES=ssl > > * use the paths set by Mk/Uses/ssl.mk > > * move post-install to post-stage > > > > Submitted by: brnrd > > > > Modified: > > head/net/openntpd/Makefile > > > > Modified: head/net/openntpd/Makefile > > =================================================================== > > =========== > > --- head/net/openntpd/Makefile Tue Jul 5 19:31:56 2016 > > (r418107) > > +++ head/net/openntpd/Makefile Tue Jul 5 19:32:17 2016 > > (r418108) > > @@ -26,18 +26,17 @@ RESSL_DESC= SSL/TLS support via > > LibreSS > > OPTIONS_DEFAULT= RESSL > > > > # Requires libtls from LibreSSL > > -RESSL_USE= openssl=yes > > -RESSL_VARS= with_openssl_port=yes > > +RESSL_USES= ssl > > RESSL_CONFIGURE_WITH= cacert=${LOCALBASE}/etc/ssl/cert.pem > > -RESSL_CPPFLAGS= -I${LOCALBASE}/include > > -RESSL_LDFLAGS= -L${LOCALBASE}/lib > > +RESSL_CPPFLAGS= -I${OPENSSLINC} > > +RESSL_LDFLAGS= -L${OPENSSLLIB} > > OPENSSLINC/LIB doesn˙t necessarily contain anything before > bsd.port.pre.mk. I think you want to assign these farther down. > > # Adam > That doesn't matter. The value of a make variable is expanded late, either when it's used in a rule, or in a .if/.for, or assigned to another variable using :=. In the cases above, what gets assigned to, e.g., RESSL_CPPFLAGS is literally the characters '-I${OPENSSLINC}', not -I followed by the expansion of the OPENSSLINC variable. -- Ian