From owner-svn-src-all@FreeBSD.ORG Sat Jul 10 18:15:56 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D6E93106566B; Sat, 10 Jul 2010 18:15:56 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id CD3A18FC21; Sat, 10 Jul 2010 18:15:55 +0000 (UTC) Received: by fxm13 with SMTP id 13so1837046fxm.13 for ; Sat, 10 Jul 2010 11:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=MFiF1dHRBvMo1RAZNZz9x6xIASuTmtXuG9Hh/EtZVoQ=; b=Y8JIwFw45TkDgI3JY++Vnu6hHqyW+r3F/h8ak/UJpIQMGbWMTfJyavWsphUttO+Rc7 g4Qyu/v4fMUKfSUiVZC4u42g4M6iE3Wm+3tpCL7tg273D9KTokBac7xk6lgk0dNJ+TkH kwsNfcyY28mITRPwUlkRZ6ge91GBLWSgvrHf8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=DNQic91tXXBFfbp3jAGnqK6Dvn8I72cu0+VCeCbzAqvhDFz+fYISTB0au9iBIszhjJ RVYb1Py1oE2nzCnNlZcz3XL5aVh+R/nTFXBviafcuOeW3GYTbWoEPEE4oAW11ME3uzGD rqclQaAXi00vcSZS757777wPL6SB1hUZjw0YA= Received: by 10.223.123.199 with SMTP id q7mr9659300far.92.1278785752193; Sat, 10 Jul 2010 11:15:52 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id q28sm4801893faa.41.2010.07.10.11.15.50 (version=SSLv3 cipher=RC4-MD5); Sat, 10 Jul 2010 11:15:51 -0700 (PDT) Sender: Alexander Motin Message-ID: <4C38B8D4.1020804@FreeBSD.org> Date: Sat, 10 Jul 2010 21:15:48 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.24 (X11/20100402) MIME-Version: 1.0 To: Doug Barton References: <201007011851.o61IpI9r054345@svn.freebsd.org> <4C38B747.9020104@FreeBSD.org> In-Reply-To: <4C38B747.9020104@FreeBSD.org> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r209634 - head/sys/x86/isa X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Jul 2010 18:15:57 -0000 Hi. Doug Barton wrote: > Did you see this message from me? Any hope of getting this fixed? Yes, sorry. I am just not sure how to properly do it. Two previous attempts appeared to be wrong: one for ISA PNP, another for ACPI. :( I'll look on it again tomorrow. > On 07/04/10 18:10, Doug Barton wrote: >> This commit results in a panic at boot time for me very early on. >> Screenshots at: >> http://people.freebsd.org/~dougb/panic-01.jpg >> http://people.freebsd.org/~dougb/panic-02.jpg >> http://people.freebsd.org/~dougb/panic-03.jpg >> >> Not sure if it's relevant or not, but after the trace is done I typed >> 'call reboot()' and it said "panic: privcheck td != curthread" >> >> This is on -current, Core 2 Duo, i386, SMP. Updating to the revision >> immediately before this one is fine, so I'm sure this is the change that >> is causing the panic. >> >> >> Doug >> >> >> On Thu, 1 Jul 2010, Alexander Motin wrote: >> >>> Author: mav >>> Date: Thu Jul 1 18:51:18 2010 >>> New Revision: 209634 >>> URL: http://svn.freebsd.org/changeset/base/209634 >>> >>> Log: >>> Rework r209456: >>> Instead of using fake rid (which ISA doesn't like), delete untrusted >>> IRQ resource and let it be recreated. >>> >>> Modified: >>> head/sys/x86/isa/atrtc.c >>> head/sys/x86/isa/clock.c >>> >>> Modified: head/sys/x86/isa/atrtc.c >>> ============================================================================== >>> >>> --- head/sys/x86/isa/atrtc.c Thu Jul 1 17:46:12 2010 (r209633) >>> +++ head/sys/x86/isa/atrtc.c Thu Jul 1 18:51:18 2010 (r209634) >>> @@ -259,7 +259,8 @@ atrtc_attach(device_t dev) >>> if (!atrtcclock_disable && >>> (resource_int_value(device_get_name(dev), device_get_unit(dev), >>> "clock", &i) != 0 || i != 0)) { >>> - sc->intr_rid = -1; >>> + sc->intr_rid = 0; >>> + bus_delete_resource(dev, SYS_RES_IRQ, sc->intr_rid); >>> if (!(sc->intr_res = bus_alloc_resource(dev, SYS_RES_IRQ, >>> &sc->intr_rid, 8, 8, 1, RF_ACTIVE))) { >>> device_printf(dev,"Can't map interrupt.\n"); >>> >>> Modified: head/sys/x86/isa/clock.c >>> ============================================================================== >>> >>> --- head/sys/x86/isa/clock.c Thu Jul 1 17:46:12 2010 (r209633) >>> +++ head/sys/x86/isa/clock.c Thu Jul 1 18:51:18 2010 (r209634) >>> @@ -535,7 +535,8 @@ attimer_attach(device_t dev) >>> tc_init(&sc->tc); >>> if (resource_int_value(device_get_name(dev), device_get_unit(dev), >>> "clock", &i) != 0 || i != 0) { >>> - sc->intr_rid = -1; >>> + sc->intr_rid = 0; >>> + bus_delete_resource(dev, SYS_RES_IRQ, sc->intr_rid); >>> if (!(sc->intr_res = bus_alloc_resource(dev, SYS_RES_IRQ, >>> &sc->intr_rid, 0, 0, 1, RF_ACTIVE))) { >>> device_printf(dev,"Can't map interrupt.\n"); >>> >>> >> > > > -- Alexander Motin