From owner-svn-ports-head@FreeBSD.ORG  Thu Aug  8 09:46:53 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id DB0541B8;
 Thu,  8 Aug 2013 09:46:53 +0000 (UTC)
 (envelope-from kevlo@FreeBSD.org)
Received: from mail.kevlo.org (220-133-188-53.HINET-IP.hinet.net
 [220.133.188.53])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7B268240C;
 Thu,  8 Aug 2013 09:46:52 +0000 (UTC)
Received: from [127.0.0.1] (mail.kevlo.org [220.133.188.53])
 by mail.kevlo.org (8.14.6/8.14.6) with ESMTP id r789kPUp089315;
 Thu, 8 Aug 2013 17:46:25 +0800 (CST)
 (envelope-from kevlo@FreeBSD.org)
Message-ID: <5203690A.4000900@FreeBSD.org>
Date: Thu, 08 Aug 2013 17:46:50 +0800
From: Kevin Lo <kevlo@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:17.0) Gecko/20130623 Thunderbird/17.0.7
MIME-Version: 1.0
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r324380 - in head/sysutils/ipad_charge: . files
References: <201308080827.r788Rj7A061308@svn.freebsd.org>
 <20130808084706.GA89089@FreeBSD.org>
In-Reply-To: <20130808084706.GA89089@FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Aug 2013 09:46:53 -0000

Alexey Dokuchaev wrote:
> On Thu, Aug 08, 2013 at 08:27:45AM +0000, Kevin Lo wrote:
>> New Revision: 324380
>> URL: http://svnweb.freebsd.org/changeset/ports/324380
>>
>> +.if ${OSVERSION} < 800000
>> +IGNORE=		requires FreeBSD 8.0-RELEASE or later
>>   .endif
> We no longer support old versions of FreeBSD like these.  Sometimes keeping
> some simple patch for a little longer is OK, but having the check merely for
> IGNORE message?.. better just kill it.
>
>> +post-install:
>> +	@${MKDIR} ${PREFIX}/etc/devd
>> +	@${SED} -e "s|%%PREFIX%%|${PREFIX}|g" \
>> +		< ${FILESDIR}/ipad_charge.conf.in > ${WRKDIR}/ipad_charge.conf
> Any reason why SUB_FILES was not used instead?
>
>> +	${INSTALL_DATA} "${WRKDIR}/ipad_charge.conf" ${PREFIX}/etc/devd
> Superfluous and inconsistent quotes.
>
>> +	@${CAT} ${PKGMESSAGE}
> It is better to pad pkg-message display with @${ECHO_CMD}'s on both sides
> to ensure consistent output (port vs. package).

All fixed now :-)  Thanks for pointing that out!

>
> ./danfe

     Kevin