Date: Thu, 08 Aug 2013 17:46:50 +0800 From: Kevin Lo <kevlo@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r324380 - in head/sysutils/ipad_charge: . files Message-ID: <5203690A.4000900@FreeBSD.org> In-Reply-To: <20130808084706.GA89089@FreeBSD.org> References: <201308080827.r788Rj7A061308@svn.freebsd.org> <20130808084706.GA89089@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexey Dokuchaev wrote: > On Thu, Aug 08, 2013 at 08:27:45AM +0000, Kevin Lo wrote: >> New Revision: 324380 >> URL: http://svnweb.freebsd.org/changeset/ports/324380 >> >> +.if ${OSVERSION} < 800000 >> +IGNORE= requires FreeBSD 8.0-RELEASE or later >> .endif > We no longer support old versions of FreeBSD like these. Sometimes keeping > some simple patch for a little longer is OK, but having the check merely for > IGNORE message?.. better just kill it. > >> +post-install: >> + @${MKDIR} ${PREFIX}/etc/devd >> + @${SED} -e "s|%%PREFIX%%|${PREFIX}|g" \ >> + < ${FILESDIR}/ipad_charge.conf.in > ${WRKDIR}/ipad_charge.conf > Any reason why SUB_FILES was not used instead? > >> + ${INSTALL_DATA} "${WRKDIR}/ipad_charge.conf" ${PREFIX}/etc/devd > Superfluous and inconsistent quotes. > >> + @${CAT} ${PKGMESSAGE} > It is better to pad pkg-message display with @${ECHO_CMD}'s on both sides > to ensure consistent output (port vs. package). All fixed now :-) Thanks for pointing that out! > > ./danfe Kevin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5203690A.4000900>