From owner-freebsd-arch@FreeBSD.ORG  Tue Feb  3 13:43:48 2004
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EB0D416A4CE
	for <freebsd-arch@freebsd.org>; Tue,  3 Feb 2004 13:43:48 -0800 (PST)
Received: from milla.ask33.net (milla.ask33.net [217.197.166.60])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9168843D39
	for <freebsd-arch@freebsd.org>; Tue,  3 Feb 2004 13:43:43 -0800 (PST)
	(envelope-from nick@milla.ask33.net)
Received: by milla.ask33.net (Postfix, from userid 1001)
	id 7AE973ABB5D; Tue,  3 Feb 2004 22:45:30 +0100 (CET)
Date: Tue, 3 Feb 2004 22:45:30 +0100
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: freebsd-arch@freebsd.org
Message-ID: <20040203214530.GB14639@garage.freebsd.pl>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="0eh6TmSyL6TZE2Uz"
Content-Disposition: inline
X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc
X-OS: FreeBSD 4.8-RELEASE-p13 i386
X-URL: http://garage.freebsd.pl
User-Agent: Mutt/1.5.1i
Subject: Non-standard ;; and SYSINIT().
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussion related to FreeBSD architecture
	<freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Feb 2004 21:43:49 -0000


--0eh6TmSyL6TZE2Uz
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello.

It looks like SYSINIT() macro is defined with trailing ;.
Maybe there was some reason to do so, but I assume that this is a bug.
There are many, many calls where an extra ; is added after SYSINIT().
SYSUNINIT() is defined without trailing ; ...

This will be ok, but ;; is not supported by ICO C (gcc -pedantic
tell me that).

Here is a patch that fix this issue at least for SYSINIT():

	http://garage.freebsd.pl/patches/SYSINIT.patch

The most important part is a change in sys/kernel.h, that removes
trailing ; from SYSINIT() definition:

-	DATA_SET(sysinit_set,uniquifier ## _sys_init);
+	DATA_SET(sysinit_set,uniquifier ## _sys_init)

AND REMEMBER! I'm not going to commit it (without strong approvals)!:)

--=20
Pawel Jakub Dawidek                       http://www.FreeBSD.org
pjd@FreeBSD.org                           http://garage.freebsd.pl
FreeBSD committer                         Am I Evil? Yes, I Am!

--0eh6TmSyL6TZE2Uz
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)

iD8DBQFAIBZ6ForvXbEpPzQRAsN7AKDrvbOnySBlqZVk6OOOG6iOeF4FnQCfRtwj
CElZwVYZIqj0PAc+CrzKfA4=
=VOMk
-----END PGP SIGNATURE-----

--0eh6TmSyL6TZE2Uz--