From nobody Sun Mar 26 18:35:34 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pl4QB3j99z429P0; Sun, 26 Mar 2023 18:35:46 +0000 (UTC) (envelope-from melifaro@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pl4QB3C5sz3tQn; Sun, 26 Mar 2023 18:35:46 +0000 (UTC) (envelope-from melifaro@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679855746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jN5E4edUvt5dyA0UrfEp684z1XWv+pGDpaaJT+bwGS8=; b=mFvXnpLmu3pnNxot2Nhb3bf1oIxybunQ3nzKtPRZoES61rNS7nKGfEZ2VZ7XqWSlIPo/Ks P9H6CtpJBIJI3sx6vR5PkRSApsLQdLp/Y6L+2vdJMRu9Ox9SqdGCLl3BNljiVAjd/PyrSl MlsweZWwRAeXqu9tbqupY2gDDyRPb9MLod4l/r4qvwjm04PkjWAhMT7QkVujt26AoQJ4Wv p8preHNv2nWSx9rEKTWUv9kPYDUSnb8SM2fwmxIdkDGVWlkL/Ke/GPPlPs5A0rXTWx6ThZ 6ido1o4prof4EDNGTcls2M+r4ZkWQQ1WB9EW/WAnOeMw8O9OGkEx5+Vvpc8akg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679855746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jN5E4edUvt5dyA0UrfEp684z1XWv+pGDpaaJT+bwGS8=; b=RUWAwc9AGuudupGtigaNBCMqypTFJflYVdgFTdNtLHGxgXCq1nufVnPwRau9GrAVhf7j5t 84UT2GIsCyP9V/ZeqR9hRJn0hQvUTBxu9SbRZAKN+Bmhx+2N27C73s7xMfx+F1BVuiSh6f uVmdYscMZv7plFbsCu8PZ4Bts+58LXPe9IA05+5oZuHP5tlGSTdOfQ539MreHmR2Lp3qOQ Y5l3zAueNCK8v/Xzw1jt7x8xJlefEm+D8DrY/2EtDe1nwzsD0yXgF+s6+MH5HuekKXLKaR syxG8CB8hGPmKWiW3b4Gt3+HyvnK5ggai1axfhj00nEEUdf1aLhxH/X5Gddhmg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679855746; a=rsa-sha256; cv=none; b=Y5qRKIPE7I17HDcQtCxTbrWKETzUtJxWJsD5frG98bQ9IDfamczDthb3F3b5bIOiQ9V3q8 6yLcp9+sXrHogL3+puGW3nnp106L48Kd+/AJfU3isyEFZ6Z+yuYZpR0Oatpw1B+iq/Cxod /31QtsqZaYzVcSW9G+etGe9aIM57H7QH5IgoOEr9znVEAySElVzO6C/z7MJpumGd9hJcwk gJFWwgmPP6JxL6hD3CfEidxtG4dQuGkB8iy3reQAvcCkQXt2lBrY7O0j0qsvuhXeOqlhZ/ UQYFIu0BeZb1xa5NtpYMSg6QgCto1lXtM+YLzrz1zwq/kiTLYGEgKpR6COdVlA== Received: from smtpclient.apple (unknown [IPv6:2a02:8084:d6bb:510:70c8:f40a:69bf:81a8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: melifaro/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Pl4Q94D3Dz14mY; Sun, 26 Mar 2023 18:35:45 +0000 (UTC) (envelope-from melifaro@freebsd.org) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Subject: Re: git: a85dcd4ac4b0 - main - netlink: restrict default userland switch to netlink to i386/amd64. From: Alexander Chernikov In-Reply-To: Date: Sun, 26 Mar 2023 19:35:34 +0100 Cc: Jessica Clarke , Ed Maste , src-committers , "" , dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <3FCBB04E-F975-42BF-B401-47EAE718FD38@freebsd.org> References: <202303261107.32QB7T7N058867@gitrepo.freebsd.org> <486C839F-181F-4CE8-8510-4A7D4D100FDC@freebsd.org> To: Warner Losh X-Mailer: Apple Mail (2.3731.400.51.1.1) X-ThisMailContainsUnwantedMimeParts: N > On 26 Mar 2023, at 18:08, Warner Losh wrote: >=20 >=20 >=20 > On Sun, Mar 26, 2023, 6:45 PM Jessica Clarke = wrote: > On 26 Mar 2023, at 17:17, Ed Maste wrote: >>=20 >>=20 >> On Sun, 26 Mar 2023 at 07:07, Alexander V. Chernikov >> wrote: >>>=20 >>> The branch main has been updated by melifaro: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Da85dcd4ac4b0612b63b5a71eeaaa707a= 09ae0003 >>>=20 >>> commit a85dcd4ac4b0612b63b5a71eeaaa707a09ae0003 >>> Author: Alexander V. Chernikov >>> AuthorDate: 2023-03-26 11:05:21 +0000 >>> Commit: Alexander V. Chernikov >>> CommitDate: 2023-03-26 11:06:53 +0000 >>>=20 >>> netlink: restrict default userland switch to netlink to = i386/amd64. >>=20 >> We should keep default options the same for all Tier-1 architectures, >> so amd64 and arm64 should be in sync. >=20 > But also, what=E2=80=99s the technical justification for this change? = There > should not be gratuitous differences between architectures like this, > only when there is a reason something shouldn=E2=80=99t be enabled. = Why should > x86 (and possibly arm64) get netlink, but not arm/powerpc/riscv? We > have very few machine-dependent defaults in src.opts.mk. If there is = no > such justification then please revert this in its entirety, and if > there is such a justification it belongs in a comment above the if. >=20 > So if it's a matter of testing, enable it everywhere. We'll get = testing. If it's something known to be bad on say riscv64 we should have = a bug and reference it in src.opts.mk to document why. If it's just a = conservative approach to a roll out, then I'd suggest being less = conservative.=20 I=E2=80=99d actually be happy to enable it everywhere and fix the bugs = if/when they appear. I=E2=80=99m not sure what is the best way to implement this. Having = Netlink on in the userland implies that route(8) (and soon ifconfig(8)) = will need kernel-side Netlink support to operate. Thus, for the particular platform, one need to ensure that either (a) = Netlink is present in the config or (b) Netlink is loaded as a module = during boot. Given that successful boot w/o working route(8) may not = just happen, it really boils down to (a). arm (like v6) or ppc or riscv may represent some lower-scale devices, = where adding Netlink to the default config may represent a size (or = other) concerns [1].=20 With all that in mind, in order to gather more datapoints & have a = gradual conversion, I started with the archs I can reason about. In the = end, it=E2=80=99s pretty easy to enable it arch-by-arch (or everywhere) = when there is a consensus on the situation mentioned above. [1] https://reviews.freebsd.org/D39047 >=20 > Warner