From owner-p4-projects@FreeBSD.ORG  Sat Aug 18 08:46:15 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id F3D4816A4A9; Sat, 18 Aug 2007 08:46:14 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9369616A419
	for <perforce@FreeBSD.org>; Sat, 18 Aug 2007 08:46:14 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247])
	by mx1.freebsd.org (Postfix) with ESMTP id 4A55513C442
	for <perforce@FreeBSD.org>; Sat, 18 Aug 2007 08:46:13 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from localhost (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id 3BE088C12F8;
	Sat, 18 Aug 2007 10:46:10 +0200 (CEST)
X-Virus-Scanned: amavisd-new at vlakno.cz
Received: from vlakno.cz ([127.0.0.1])
	by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id nKYtC+ZpuVQN; Sat, 18 Aug 2007 10:46:08 +0200 (CEST)
Received: from vlk.vlakno.cz (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id E0CE98C12F7;
	Sat, 18 Aug 2007 10:46:08 +0200 (CEST)
Received: (from rdivacky@localhost)
	by vlk.vlakno.cz (8.13.8/8.13.8/Submit) id l7I8k8rU071163;
	Sat, 18 Aug 2007 10:46:08 +0200 (CEST) (envelope-from rdivacky)
Date: Sat, 18 Aug 2007 10:46:08 +0200
From: Roman Divacky <rdivacky@FreeBSD.org>
To: Jesper Brix Rosenkilde <jbr@FreeBSD.org>
Message-ID: <20070818084608.GA70909@freebsd.org>
References: <200708172057.l7HKvMhw000824@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200708172057.l7HKvMhw000824@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 125277 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Aug 2007 08:46:15 -0000

>       struct image_params *imgp;
>  {
>  	int error;
> +	struct proc *p = imgp->proc; 
>  	vm_map_t map = &imgp->proc->p_vmspace->vm_map;
>  	vm_offset_t *addr = &imgp->proc->p_usrsysshm;
> -	int test = 42;
> +	struct sysshm outsysshm;
>  
>  	error = vm_map_sysshm(map, addr, 42);
>  
> -	copyout((caddr_t) &test, (caddr_t) *addr, sizeof(int)); 
> +	outsysshm.pid = p->p_pid;
> +	strncpy(outsysshm.progtitle, p->p_comm, MAXCOMLEN);
> +	strncpy(outsysshm.proctitle, "\0", 1);
> +	copyout((caddr_t) &outsysshm, (caddr_t) *addr, sizeof(struct sysshm)); 
  

the p->p_comm can be changed under your hands. you need to lock "p" and obtain
local copy and copyout the local copy.

> +struct sysshm {
> +	pid_t pid;
> +	char progtitle[20];
> +	char proctitle[2048];
> +};

please use some defines here... I think you want to use MAXCOMLEN+1