From owner-dev-commits-src-main@freebsd.org Thu Apr 15 20:20:26 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8C4A55D6080 for ; Thu, 15 Apr 2021 20:20:26 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FLrLf3DVWz4nmq for ; Thu, 15 Apr 2021 20:20:26 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qt1-x832.google.com with SMTP id y12so19213636qtx.11 for ; Thu, 15 Apr 2021 13:20:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vstwmu7liHtazxlPIZhkiQVqaJ+UejrHstDe/X11TtE=; b=TPi6NqAH/Tj/r+eo3P7otwAglRr+ky7p42o7pewxQoa2l/D2nMsMSQTt1MCJfIGa2j oGoujjR5UpCRY2s00+KZYzjV8u7F+fTe16bYOKVVu2YifuBsi+yh9pxewnxi+xnnJR3b BoaIkGJzUMuApCvQXcn3CgW/jtQw9vTE8JWubhLlOCoT8l3J/9Z7YPDAfRKcZpkUVPxA 8e0yta+NBgquvmo2qsL/OjOzmaya2jxFNTZkpM2c2mA06f8Y0cG2KMXh2zkKaIWujQ5I fvxfN4JkPu5Ugg8HbPAAEBbPTcJjHrnt4yF20EwAqJ20v/6oc0CBRr2kFl7bcgMaovcc ZALA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vstwmu7liHtazxlPIZhkiQVqaJ+UejrHstDe/X11TtE=; b=XCLBRogILAemjJTNX0MgVuJ6eYyhj46z0N68bJ+nPc6JTHAFBKZIrGpK/jLw0c0bdb 4YxgP/PBgBwYUrq8x0xiGuWgI7q/rqZRrbmGWent8lTpsTvwgjGizJRlvB3Z/QJ/K329 WwSkuwHPeVShxjvwP3HQrpiFQAS3g7fVJNnBI/dceZLNi4OOuR54UwwJYkflXXgyi6Jl OVo+JJ/DTZY2QVQB8Pu7edvNZgH5H44zySiEtRYKR2LhaS3+Yr/ETw/EMQjprl2xh8Zf kGqKECBngdIbbgrrfNica9czt20lEh4iKJPQX9JlFJCmhotUVO7m/6jdBT0abtHhHaq3 u0Gg== X-Gm-Message-State: AOAM531uJIACTqMx/Q7zbTWgBG3Jyt0fmnjlPDgUnecf+zr4/MEiG/3K kwK8d1nmoXv6IvgqjIrCxHUiuQ== X-Google-Smtp-Source: ABdhPJzTCiUrPe1xrP11UdWRLMgjBEjay4vbmneNPeOqHhHmSceiB+NYUhRqX/zFX0U1AojnN8btCw== X-Received: by 2002:ac8:6f13:: with SMTP id g19mr4695614qtv.268.1618518025438; Thu, 15 Apr 2021 13:20:25 -0700 (PDT) Received: from mutt-hbsd (pool-100-16-222-53.bltmmd.fios.verizon.net. [100.16.222.53]) by smtp.gmail.com with ESMTPSA id l24sm2515230qtp.18.2021.04.15.13.20.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Apr 2021 13:20:24 -0700 (PDT) Date: Thu, 15 Apr 2021 16:20:23 -0400 From: Shawn Webb To: Kyle Evans Cc: Kevin Bowling , Ronald Klop , Kevin Bowling , src-committers , "" , dev-commits-src-main@freebsd.org Subject: Re: git: 68a46f11eada - main - e1000: Restore VF interface random MAC Message-ID: <20210415202023.oms4sih6eina57xu@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 14.0-CURRENT-HBSD FreeBSD 14.0-CURRENT-HBSD X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <202104151848.13FImMA5091035@gitrepo.freebsd.org> <5b50b23a-71cd-5221-c905-ccffe841bc98@klop.ws> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="76ntzjfnoskhjo4p" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4FLrLf3DVWz4nmq X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Apr 2021 20:20:26 -0000 --76ntzjfnoskhjo4p Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Could ether_gen_addr be updated to take into account the zero'd hostuuid and handle appropriately like you mentioned below?=20 On Thu, Apr 15, 2021 at 03:12:14PM -0500, Kyle Evans wrote: > I think it'd be the right choice, but it needs a little work first. > e.g., it's not a good fit right now for VMs that don't use loader, for > instance, because it relies on the hostuuid actually being somewhat > unique or else it generates the same MAC address across different VMs > and you end up with conflicts in the broadcast domain. I think there's > a good argument to make for having it check if the hostuuid is the > default all-0 hostuuid and just generating a random address as this > does right now. I might go ahead and prepare such a change and > document the KPI in the process. >=20 > On Thu, Apr 15, 2021 at 3:06 PM Kevin Bowling = wrote: > > > > I would like to discuss this further, it crossed my mind, but none of > > the intel drivers currently use it. If this is the right KPI I think > > a review should be prepared that updates e1000, ixgbe (ixv), ixl > > (iavf) in one go. > > > > Regards, > > Kevin > > > > On Thu, Apr 15, 2021 at 12:36 PM Kyle Evans wrote: > > > > > > On Thu, Apr 15, 2021 at 2:32 PM Ronald Klop wr= ote: > > > > > > > > On 4/15/21 8:48 PM, Kevin Bowling wrote: > > > > > The branch main has been updated by kbowling (ports committer): > > > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D68a46f11eadab48a1d= a9e3d3900569a6a1ce142e > > > > > > > > > > commit 68a46f11eadab48a1da9e3d3900569a6a1ce142e > > > > > Author: Kevin Bowling > > > > > AuthorDate: 2021-04-15 18:45:02 +0000 > > > > > Commit: Kevin Bowling > > > > > CommitDate: 2021-04-15 18:45:02 +0000 > > > > > > > > > > e1000: Restore VF interface random MAC > > > > > > > > > > Restore 525e07418c77 after the iflib conversion of igb(4). T= his > > > > > reenables random MAC address generation when attaching to a = VF with a > > > > > zeroed MAC. > > > > > > > > > > PR: 253535 > > > > > Reported by: Balaev PA > > > > > Reviewed by: markj > > > > > MFC after: 2 weeks > > > > > Differential Revision: https://reviews.freebsd.org/D29785 > > > > > --- > > > > > sys/dev/e1000/if_em.c | 21 ++++++++++++++++++--- > > > > > 1 file changed, 18 insertions(+), 3 deletions(-) > > > > > > > > > > diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c > > > > > index 6f022c80c01c..79a617b3342f 100644 > > > > > --- a/sys/dev/e1000/if_em.c > > > > > +++ b/sys/dev/e1000/if_em.c > > > > > @@ -1061,9 +1061,17 @@ em_if_attach_pre(if_ctx_t ctx) > > > > > } > > > > > > > > > > if (!em_is_valid_ether_addr(hw->mac.addr)) { > > > > > - device_printf(dev, "Invalid MAC address\n"); > > > > > - error =3D EIO; > > > > > - goto err_late; > > > > > + if (adapter->vf_ifp) { > > > > > + u8 addr[ETHER_ADDR_LEN]; > > > > > + arc4rand(&addr, sizeof(addr), 0); > > > > > + addr[0] &=3D 0xFE; > > > > > + addr[0] |=3D 0x02; > > > > > + bcopy(addr, hw->mac.addr, sizeof(addr)); > > > > > + } else { > > > > > + device_printf(dev, "Invalid MAC address\n"); > > > > > + error =3D EIO; > > > > > + goto err_late; > > > > > + } > > > > > > > > > > > > Just curious. Would ether_gen_addr() be useful here? > > > > It is implemented in net/if_ethersubr.c. > > > > > > > > > > I had asked myself the same question, but I suspect these machines may > > > not necessarily have a hostuuid preloaded to avoid collisions from the > > > generated addresses. > > > > > > Thanks, > > > > > > Kyle Evans > _______________________________________________ > dev-commits-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all > To unsubscribe, send any mail to "dev-commits-src-all-unsubscribe@freebsd= =2Eorg" --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --76ntzjfnoskhjo4p Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmB4oAQACgkQ/y5nonf4 4fpOuw//eLn9TUkn8GZdpfAd4mWpX7rWBsjV1XuybzynIZF0pzwSOv3VJY4BTMFq KRnVNSd2vjjE55mlTLqQQ3UxH0qEIjK1ZYAHZ5Hv4EJ0CGmtn6MckPlKF6Jd8OK5 YcIAMx/qmmgaDviPAvtaRZiyUkLJB2Kpv/LZ0ClBCUMm4pSQghvhUfIl8gEfeG0K iBrfKQLW/b+llOGsBVAZqe9xBRt2vMJ57n11WvtAJZ+JxaaI7TwQvh/yN7M4syzF 3KfX5hm7Uc0phGDFs8eCobx3Km3kG4U9+NQ+zt7kPbKWcAFjoAJJx1tnIbyvHj+W W2DBjSD1gpY9/BFYDEJxsV0lu89sVcUcwR4VruhWcHVEWM6Vm0VXEpIxvHsnCLcs ot3Lp+xwBpgywjC5KtrgF789okj3s/c4ynhpJ1APitAluSgv75TMmnX5qUiNhcb5 18L+bKAGxG5H/z9NVDO1T6C61gguQWmdBue7usplCt1OOIpIQS4Yo6FeSVcDwOhF TOGeUAMXq5f8nzF1YPBDzUtGXTTMMBY6utjtBO2PSZEkrP6gigrWMtvOEaPYv03k qxA06dS44BtvtjxNJuFbTjuT6bCwpjqAbbM0kRRm4IyKchPNjDdtt3DEbzSrhk8Y RaZwQzZnp7/aDEE3JWNRSFqJJ97ZQvSm41/V/cr/6LkFxlVQ9aA= =mTbI -----END PGP SIGNATURE----- --76ntzjfnoskhjo4p--