From owner-svn-src-all@FreeBSD.ORG Fri Oct 24 19:32:06 2008 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 421761065680; Fri, 24 Oct 2008 19:32:06 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from out3.smtp.messagingengine.com (out3.smtp.messagingengine.com [66.111.4.27]) by mx1.freebsd.org (Postfix) with ESMTP id 11D478FC41; Fri, 24 Oct 2008 19:32:06 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from compute2.internal (compute2.internal [10.202.2.42]) by out1.messagingengine.com (Postfix) with ESMTP id 8406B1819EF; Fri, 24 Oct 2008 15:32:05 -0400 (EDT) Received: from heartbeat2.messagingengine.com ([10.202.2.161]) by compute2.internal (MEProxy); Fri, 24 Oct 2008 15:32:05 -0400 X-Sasl-enc: Qo/NhmF1kFwZVHnNRLEMDYJxo9bn+3PkfIMIF5PW0HNR 1224876725 Received: from empiric.lon.incunabulum.net (82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254]) by mail.messagingengine.com (Postfix) with ESMTPSA id E99C2253CA; Fri, 24 Oct 2008 15:32:03 -0400 (EDT) Message-ID: <490222B1.8070205@FreeBSD.org> Date: Fri, 24 Oct 2008 20:32:01 +0100 From: "Bruce M. Simpson" User-Agent: Thunderbird 2.0.0.14 (X11/20080514) MIME-Version: 1.0 To: Marcel Moolenaar References: <200810230216.m9N2Gdxw045106@svn.freebsd.org> <20081023.191014.41711418.imp@bsdimp.com> <49018C68.3020706@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, marcel@FreeBSD.org, Warner Losh , src-committers@FreeBSD.org Subject: Re: svn commit: r184194 - in head/sys: conf mips/conf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Oct 2008 19:32:06 -0000 Marcel Moolenaar wrote: > > I have no problem reverting, but the reasons you put forward > don't hold. uart(4) is not enabled by default so there's no > change to the SENTRY5 configuration at all in that respect. OK, most of the uarts I've seen, but not all, on the MIPS boards, are 16C550 style UARTs. All the same it would be desirable not to enable 'options uart_ns8520' in all cases. > Please provide other grounds for reversal. I didn't point this out in my original message, but my concern with the commit as a whole, was more to do with the fact that GEOM_MBR and GEOM_BSD were being enabled by default. For a kernel shipping on a system where there are no UFS filesystems or DOS style partitions, and often a 1MB kernel size limit (which may be compressed) it might be more desirable not to ship those by default. Same re uart_ns8250. thanks, BMS