From owner-svn-src-all@freebsd.org Tue Apr 14 22:37:43 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 62B3E2CB7B9; Tue, 14 Apr 2020 22:37:43 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4920jy5gm8z3NyZ; Tue, 14 Apr 2020 22:37:42 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 8F4003C0199; Tue, 14 Apr 2020 22:37:36 +0000 (UTC) Date: Tue, 14 Apr 2020 22:37:36 +0000 From: Brooks Davis To: Conrad Meyer Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r359937 - in head/sys: amd64/linux amd64/linux32 arm64/linux compat/freebsd32 compat/linux dev/ipmi dev/mpr dev/mps dev/mpt i386/linux kern sys Message-ID: <20200414223736.GA78726@spindle.one-eyed-alien.net> References: <202004142030.03EKUmOJ080400@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YZ5djTAD1cGYuMQK" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 4920jy5gm8z3NyZ X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2020 22:37:43 -0000 --YZ5djTAD1cGYuMQK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 14, 2020 at 03:08:24PM -0700, Conrad Meyer wrote: > Brooks, >=20 > On Tue, Apr 14, 2020 at 13:31 Brooks Davis wrote: >=20 > > Author: brooks > > Date: Tue Apr 14 20:30:48 2020 > > New Revision: 359937 > > URL: https://svnweb.freebsd.org/changeset/base/359937 > > > > Log: > > Centralize compatability translation macros. > > > > Copy the CP, PTRIN, etc macros from freebsd32.h into a sys/abi_compat= =2Eh > > and replace existing definitation with includes where required. This > > eliminates duplicate code and allows Linux and FreeBSD compatability > > headers to be included in the same files. > > > > Input from: cem, jhb >=20 >=20 > You dismissed my input, so I don???t think there???s a good reason to sug= gest I > was involved with the revision. I apologize. I did make some (admittedly trivial) changes in response to your feedback and thought it was worth a mention. Your other proposed suggestions do seem worth exploring, but they were an enormous expansion of scope from a tiny bit of code consolidation to touching a large portion of macro sites. -- Brooks --YZ5djTAD1cGYuMQK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJeljsvAAoJEKzQXbSebgfAY0wIAI97gpft0KBgvTP2z58mBLbU n1jdfZh7Pf5ahr50MErTS4SlVBQJnEv8VbBmz1YPoj+4LvTRGNrc3GJ+h++zPR1M GJ8FC9kDJk6ltq6hzw0GqVPDXrwuOoJaILmlfHv56dyEKWXoC9/mbMW7pKDlr1gD ZSiJyCfpD3jhA4GD34Pl6UmHx+2ccKhYmprbrR5jtY8Xo6CrAcPzcGIpx4F3BrxD NMqd1Gqf4i7FNkMsaUIfoRYAt1receh4LZ+XQAHcn2W9nPf9InoIg/KSxQUy2cf9 gnl6HT9rIglBb27af34ETmMiG5BeYNSRFINBgjQjNYPLKRy+/itJNUWDx+0cClY= =MZ+3 -----END PGP SIGNATURE----- --YZ5djTAD1cGYuMQK--