Date: Thu, 13 Oct 2005 15:37:31 +0400 From: Sergey Matveychuk <sem@FreeBSD.org> To: "Michael C. Shultz" <ringworm01@gmail.com> Cc: "Mark J. Sommer" <msommer@argotsoft.com>, hackers@freebsd.org, RW <list-freebsd-2004@morbius.sent.com> Subject: Re: portmanager Message-ID: <434E46FB.1090800@FreeBSD.org> In-Reply-To: <200510121515.14805.ringworm01@gmail.com> References: <200510122033.j9CKX5uo040708@argotsoft.com> <200510121515.14805.ringworm01@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Michael C. Shultz wrote:
>
> if ( getenv("TERM") )
> {
> . . .
> }
Anyway you should use code like that for the cases:
char *term;
term = getenv("TERM");
And check the variable afterwards. It much better than call getenv() twice.
And the first condition would be:
if( term && !strncmp( term, "xterm", 5 ) && isatty(fileno(stdout)) )
And some people not recomend use '!' with str[n]cmp(). Using '== 0' is
better.
It was someting about a code style.
--
Sem.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?434E46FB.1090800>