From owner-cvs-all@FreeBSD.ORG  Wed Jul  4 14:42:51 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 2BFD216A421;
	Wed,  4 Jul 2007 14:42:51 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69])
	by mx1.freebsd.org (Postfix) with ESMTP id 8BA9613C44B;
	Wed,  4 Jul 2007 14:42:50 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l64EgnxT031474;
	Wed, 4 Jul 2007 18:42:49 +0400 (MSD)
	(envelope-from ache@nagual.pp.ru)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nagual.pp.ru;
	s=default; t=1183560169; bh=M9DFbagWTerF/OwoNy8T3TknqtEX4hpWBiEZLnh
	APM8=; l=537; h=Received:Date:From:To:Cc:Subject:Message-ID:
	Mail-Followup-To:References:MIME-Version:Content-Type:
	Content-Disposition:In-Reply-To:User-Agent; b=lcqhPUVo7EIWRZ1KMLrn
	zCClkcP6UuI3EcqNtLUKUdAJZJIn2nUOzweUhR+rd2cs8bJeW44+uJivfXvCxeMvJOQ
	64f6mbtfHCRAx4706ZiZcI/xkQAYFskywB3APruhFAfoVCRf2AtMP3ej7J25K3SMFkp
	Aa/mDnFoNmYsVrwdk=
Received: (from ache@localhost)
	by nagual.pp.ru (8.14.1/8.14.1/Submit) id l64EgnF3031473;
	Wed, 4 Jul 2007 18:42:49 +0400 (MSD) (envelope-from ache)
Date: Wed, 4 Jul 2007 18:42:49 +0400
From: Andrey Chernov <ache@nagual.pp.ru>
To: Sean Farley <scf@FreeBSD.org>
Message-ID: <20070704144249.GB31254@nagual.pp.ru>
Mail-Followup-To: Andrey Chernov <ache@nagual.pp.ru>,
	Sean Farley <scf@FreeBSD.org>, src-committers@FreeBSD.org,
	cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
References: <200707040000.l6400gLs044775@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200707040000.l6400gLs044775@repoman.freebsd.org>
User-Agent: Mutt/1.5.16 (2007-06-09)
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/bin/df df.c src/bin/sh var.c src/include
	stdlib.h src/libexec/pppoed pppoed.c src/sys/sys param.h
	src/lib/libc/stdlib Makefile.inc getenv.3 getenv.c putenv.c
	setenv.c src/tools/regression/environ Makefile Makefile.envctl ...
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jul 2007 14:42:51 -0000

On Wed, Jul 04, 2007 at 12:00:41AM +0000, Sean Farley wrote:
>   Several patches to base utilities to handle the POSIX changes from
>   Andrey Chernov's previous commit.  A few I re-wrote to use setenv()
>   instead of putenv().

Replacing putenv() with setenv() should care about the case when putenv() 
uses getenv()-provided value directly, like in sh's var.c. It should be 
copied by strdup() or something like first to not break env before 
following setenv() call. 

In my patch I always care about this.

-- 
http://ache.pp.ru/