From owner-cvs-all@FreeBSD.ORG Wed Apr 30 10:19:23 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7865C37B40F for ; Wed, 30 Apr 2003 10:19:23 -0700 (PDT) Received: from mail.speakeasy.net (mail12.speakeasy.net [216.254.0.212]) by mx1.FreeBSD.org (Postfix) with ESMTP id F167143FE9 for ; Wed, 30 Apr 2003 10:19:21 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 22561 invoked from network); 30 Apr 2003 17:19:26 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 30 Apr 2003 17:19:26 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.8/8.12.8) with ESMTP id h3UHI4Ov022161; Wed, 30 Apr 2003 13:18:04 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <16046.62962.818957.664893@grasshopper.cs.duke.edu> Date: Wed, 30 Apr 2003 13:18:09 -0400 (EDT) From: John Baldwin To: Andrew Gallatin cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: "M. Warner Losh" cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Apr 2003 17:19:24 -0000 On 29-Apr-2003 Andrew Gallatin wrote: > > John Baldwin writes: > > > > Well, this also now involves extra locking in ithread_loop() (though we > > should be doing it anyway). I'm kind of busy doing sigacts locking so > > I can finally get all of signal handling out from under Giant, but I > > can come back to this after that. > > Thanks, I appreciate that. > > What really needs to come out from under giant is uiomove. > I'll be the first to admit that I have no idea what would be involved > in that. If you are using a private uio structure then it doesn't need Giant. copyin/copyout only need Giant if they fault and they will already get it in that case. bcopy() doesn't need Giant. The per-thread flag is already locked. uio_yield() is already Giant-free. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/