From owner-svn-src-head@freebsd.org Fri Jan 25 21:38:08 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6EA6214C3E03; Fri, 25 Jan 2019 21:38:08 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0600974472; Fri, 25 Jan 2019 21:38:07 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-ot1-f47.google.com with SMTP id t5so9912146otk.1; Fri, 25 Jan 2019 13:38:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4vVyULC4t3i26dKwAq9edILzA+WtsYH6/Yp3i1Ucq8o=; b=sJnbgWlu/WBsNg2jXgGxinmM6Bz9LUqhTz6jpmlkqRAiHR3uVjLRp+awDSYELldpIi aYqwWZPfUqwQoq5r+yRnFZaozWzlDZCr4MvcXJ9uW1MxaVaXwICxsprLopabCgi4tQPr g/y+lg1fswaIMfLVZQa4xgGXsnfj2xsh+4WrJmH8PBfkvj44z7yTtouBJ6D4efJvnfZ9 BJTRZ1J1f+5J9cca1dYJwd0mm0a5LzlXh9CIHDYi61id/SS1ra1e1kOV5FtMqGTEebxY XrRaL6bpdIGJNVp13+/R5EqvFUVfqII0VhXo+gLCe53OQCI1MNQ12ZSk1WDM/ZAY7ZI6 mWNA== X-Gm-Message-State: AJcUukdUsIHL0wWU3weeiPGt6+i7TiOo3Ksyc77uS/vovgHyBo7dVfvJ U9WBvUyqWCyEhb4JFMz6sbIm4CZqzubZ+j56KcAQEA== X-Google-Smtp-Source: ALg8bN4Rn0+mj8HC7CXPGeS5M4l3ZqqmsFAO0mnhnEzdg2ZOvGYk/kuv8cY9AH1m2Fp1kvk3tww3chCv8seyJYv55t0= X-Received: by 2002:a9d:7450:: with SMTP id p16mr8433257otk.247.1548452280892; Fri, 25 Jan 2019 13:38:00 -0800 (PST) MIME-Version: 1.0 References: <201901251709.x0PH9Rc4094379@repo.freebsd.org> <201901251957.x0PJvdTL089917@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201901251957.x0PJvdTL089917@pdx.rh.CN85.dnsmgr.net> From: Edward Napierala Date: Fri, 25 Jan 2019 21:37:49 +0000 Message-ID: Subject: Re: svn commit: r343440 - head/bin/sh To: rgrimes@freebsd.org Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 0600974472 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.48 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.48)[-0.483,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 21:38:08 -0000 pt., 25 sty 2019 o 19:57 Rodney W. Grimes napisa=C5=82(a): > > > Author: trasz > > Date: Fri Jan 25 17:09:26 2019 > > New Revision: 343440 > > URL: https://svnweb.freebsd.org/changeset/base/343440 > > > > Log: > > Comment out the default sh(1) aliases for root, introduced in r343416= . > > The rest of this stuff is still to be discussed, but I think at this > > point we have the agreement that the aliases should go. > > > > MFC after: 2 weeks > > Sponsored by: DARPA, AFRL > > Please just revert this and the prior commit out, and when > the path forward is clear commit it. I would not want any of this > merged to 12/ or 11/ until the time that it is all settled. Oops, my bad - neither this nor the previous commit is supposed to be MFC-ed; the "2 weeks" above comes from my default Subversion config. Regarding the backoff - just a few hours ago you said you don't have any problem with this, except for aliases and the default ENV. The aliases problem has been addressed, and you hadn't yet responded to my explanations regarding the ENV. Another committer asked for backoff, because "sh is not an interactive shell", while in fact sh(1) is FreeBSD's default interactive shell except for root. Finally, there's one person who asked for revert, but without giving any reasons whatsoever. So far nobody had proposed any scenario where this would break anything, or even affect existing users. It seems like a typical bikeshed situation.