From owner-freebsd-current Wed Jan 27 22:29:44 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA21710 for freebsd-current-outgoing; Wed, 27 Jan 1999 22:29:44 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from ns.mt.sri.com (sri-gw.MT.net [206.127.105.141]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id WAA21704 for ; Wed, 27 Jan 1999 22:29:41 -0800 (PST) (envelope-from nate@mt.sri.com) Received: from mt.sri.com (rocky.mt.sri.com [206.127.76.100]) by ns.mt.sri.com (8.8.8/8.8.8) with SMTP id XAA11205; Wed, 27 Jan 1999 23:29:38 -0700 (MST) (envelope-from nate@rocky.mt.sri.com) Received: by mt.sri.com (SMI-8.6/SMI-SVR4) id XAA26798; Wed, 27 Jan 1999 23:29:37 -0700 Date: Wed, 27 Jan 1999 23:29:37 -0700 Message-Id: <199901280629.XAA26798@mt.sri.com> From: Nate Williams MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: Matthew Dillon Cc: Nate Williams , Archie Cobbs , wollman@khavrinen.lcs.mit.edu (Garrett Wollman), current@FreeBSD.ORG Subject: Re: btokup() macro in sys/malloc.h In-Reply-To: <199901280603.WAA93627@apollo.backplane.com> References: <199901280222.VAA14212@khavrinen.lcs.mit.edu> <199901280229.SAA20207@bubba.whistle.com> <199901280540.WAA26288@mt.sri.com> <199901280603.WAA93627@apollo.backplane.com> X-Mailer: VM 6.34 under 19.16 "Lille" XEmacs Lucid Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > :> then we need to update sytle(9) to reflect that. > :> > :> In fact, style(9) should say: > :> > :> If at all possible, your code should compile without warnings > :> when the gcc -Wall flag is given. > : > :I disagree. As has been shown many times in the past (and I suspect the > :down-under constituent will show that at least a couple of the > :'warnings' fixes will be wrong and hide bogus code), making -Wall a goal > :causes people to cover up bad code with bad casts and such. > : > :'-Wall' is *NOT* a good design goal. > > Nonsense. -Wall does *NOT* contribute to a bad programmer programming > badly, and I found at least three fairly serious mistakes when I turned > it on. And introduced at least one. If you were a programmer under my charge, I'd tell you to use the warnings to fix only those bugs you are sure of and leave the others alone. > I mean, come on... by your argument the compiler might as well give up > and not bother warning you about anything! A warning is just that. It's not an error, so don't treat it like one. Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message