From owner-svn-src-all@FreeBSD.ORG  Wed Oct  1 20:33:32 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 3C2252DB
 for <svn-src-all@freebsd.org>; Wed,  1 Oct 2014 20:33:32 +0000 (UTC)
Received: from mail-qc0-f174.google.com (mail-qc0-f174.google.com
 [209.85.216.174])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id EDD75302
 for <svn-src-all@freebsd.org>; Wed,  1 Oct 2014 20:33:31 +0000 (UTC)
Received: by mail-qc0-f174.google.com with SMTP id m20so1108411qcx.33
 for <svn-src-all@freebsd.org>; Wed, 01 Oct 2014 13:33:30 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=6A8bZeX4025K5YBj1l1gy/z+RwFBe2d95rsvBDhyIRw=;
 b=EwpJWTbeFWmupxs1vk/xNalzoV7KqK6Ofl5gg9lt7MfFusHiNrPEap+DXwiYVXf7Tf
 vGqpb5KViO0fH30ZQG32SvqQH5eo4nayd0HMj5FaoThSCYcPeXaBlXmUivYk5euN7+I1
 Nue9G2AdHOLyHYlNr6bhuix8/SooEPGHh3uHBdvjcQx0JdKSu+Tnmu3BqO0tKa/vqbZ1
 /Sa2NBkgeikrfoTzhSCBtSsqXWi65UdH3aynDDIjzwIlki0oOSvOzlF5frweh7vCQpbL
 TyyP8ORxalB83H6vz0BGOpk3hoo5C2bJ9ZIgJ4pHbQN4gPdItls0ZgpNLJmKhpbddnXI
 9KgQ==
X-Gm-Message-State: ALoCoQlFlmKyzZ0/MnG6JxkMEZdHFSuHmDi/0jDjG7l1+1wzcdZFd67LNf5eGfCPaIfrfaYNE9Ss
MIME-Version: 1.0
X-Received: by 10.224.32.138 with SMTP id c10mr67036630qad.1.1412195610628;
 Wed, 01 Oct 2014 13:33:30 -0700 (PDT)
Received: by 10.140.31.36 with HTTP; Wed, 1 Oct 2014 13:33:30 -0700 (PDT)
In-Reply-To: <542C6087.2060909@FreeBSD.org>
References: <201409291505.s8TF5Nhh066884@svn.freebsd.org>
 <542C14F6.7020506@FreeBSD.org>
 <CADBaqmgnJzrev_cYaJyXABABp5b0y7=5cGFDc1oovgs=-jRVyg@mail.gmail.com>
 <542C4FEC.8010800@FreeBSD.org>
 <CADBaqmjz1aCQhQa5YMNym78jnBhiQ=Etjz1W5Hc6nOe=MygQFA@mail.gmail.com>
 <542C6087.2060909@FreeBSD.org>
Date: Wed, 1 Oct 2014 14:33:30 -0600
Message-ID: <CADBaqmiBH1L2Q2eRdovSFS6JKQWkvM6u3DTAAWmZ9Ka4ynxaZw@mail.gmail.com>
Subject: Re: svn commit: r272282 - head/share/mk
From: Will Andrews <will@firepipe.net>
To: Jung-uk Kim <jkim@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: Baptiste Daroussin <bapt@freebsd.org>,
 "src-committers@FreeBSD.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 Bryan Drewery <bdrewery@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 Guido Falsi <madpilot@freebsd.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Oct 2014 20:33:32 -0000

On Wed, Oct 1, 2014 at 2:13 PM, Jung-uk Kim <jkim@freebsd.org> wrote:
> Actually, portmaster.diff is just enough to fix portmaster problem.
> ports.diff is for consistency.

So I guess portmaster is doing a string comparison to decide whether
to install a port?  That sounds like a bug in portmaster.  I suggest
changing it to always ask make for the value of PORTSDIR.

--Will.