From owner-dev-commits-src-all@freebsd.org Thu Jan 14 13:26:41 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7AC0D4E22FB; Thu, 14 Jan 2021 13:26:41 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DGlTF2gchz3rgY; Thu, 14 Jan 2021 13:26:41 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wr1-x429.google.com with SMTP id d26so5742690wrb.12; Thu, 14 Jan 2021 05:26:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=W/fhBpck4o3yfpKz+UO+mubR0deFHuVxxf49jMMG/SE=; b=iUvU8qb89pBZ16VeKii1XZu16AHs1FSS6Cw028VfeBlOjTnw2liNqqcCFW1uAdhLs6 vJ96/l++gJu//3h9M+pL5czI7b/BZvSYjkbm0SDp2M2Tai2kaWioyhWJZi3UowkzbKGL hGP82lLoMe6VDFwmQp5nG4BQPT90tapnJvb6opfhLw1RWe8OXCUwWuq5GDP/ugKps6sd 0rzCHrEbVZ1iq7sopPMvdV7a+ukl4GsG8qD3clEcLfP6whk7t/mygQGxzxGCglIxllV/ y+JDFLQGVj6FCch5lPVcC8uv9jUg5ZHPGxV3m8AKnYcqWo8+RD2dhtEuJINCU9MqabTi qVuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=W/fhBpck4o3yfpKz+UO+mubR0deFHuVxxf49jMMG/SE=; b=QANDRtcWpIFdsCD6qrNZvtAnVTYG81dBBY9x7NKSaMBS3jRw55dNMjCp1t5E14SwpY 6+hGL2wy2eh4dShJvULDGvTDrqvFcBRsETeo8Y+BAmWBrPoszW72A0EEsyrnZ5SOBSS6 cqN2V8/wTd0AqSa52YTcM1rQ+627uwZZeg6aEGMXPp2uWnFGhKYyZEhpHtvXuALqiVq5 3HWrvoMAQtF9RwMx3OFY4RzqL70KOOamD10+tT4vfMIof5teZlu+PGstztXBLM+ynGC4 TvZP0+YJOhugFTyKaZOheCwi7fKBHSInCQktPZkIfHQlJxBhMrlWpaGDQS8RTrSHr3UZ lQYA== X-Gm-Message-State: AOAM533mSTZyxJSDsvA28NvYt/Z//wtmg3IWzm5Qfvw9dw6nnivoBfk8 5LPCyoFgb7xH+fllBaIpkyI++5UR4PMPrm1+JjXSdfse X-Google-Smtp-Source: ABdhPJxTxTAcs69YFN+TSxuXSHoklb/BNUrLY+foKJb1JN8xudkJDyz8xFho4FtAyHTO2P1qJjSxxdxJHHhzKQ5T5fk= X-Received: by 2002:adf:ec86:: with SMTP id z6mr7936449wrn.17.1610630799414; Thu, 14 Jan 2021 05:26:39 -0800 (PST) MIME-Version: 1.0 Received: by 2002:adf:f811:0:0:0:0:0 with HTTP; Thu, 14 Jan 2021 05:26:38 -0800 (PST) In-Reply-To: <202101140704.10E74KhX070996@gitrepo.freebsd.org> References: <202101140704.10E74KhX070996@gitrepo.freebsd.org> From: Mateusz Guzik Date: Thu, 14 Jan 2021 14:26:38 +0100 Message-ID: Subject: Re: git: bd72252aace3 - main - [mips] revert r366664 - flip mips back from -O2 to -O To: Adrian Chadd Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4DGlTF2gchz3rgY X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2021 13:26:41 -0000 This breaks tinderbox, for example: make[5]: "/usr/src/share/mk/sys.mk" line 169: Malformed conditional (${MACHINE_CPUARCH} == "mips" && ${COMPILER_TYPE} == "gcc") make[5]: Fatal errors encountered -- cannot continue make[5]: stopped in /usr/obj/usr/src/mips.mips64/sys/BERI_NETFPGA_MDROOT On 1/14/21, Adrian Chadd wrote: > The branch main has been updated by adrian: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=bd72252aace382921840ddbceea712b96f4ad242 > > commit bd72252aace382921840ddbceea712b96f4ad242 > Author: Adrian Chadd > AuthorDate: 2021-01-12 21:13:20 +0000 > Commit: Adrian Chadd > CommitDate: 2021-01-14 07:03:53 +0000 > > [mips] revert r366664 - flip mips back from -O2 to -O > > Now that I have -head fitting in 8MB of flash again, I can test > out freebsd-head on my home AP test setup. Unfortunately, > the introduction of -O2 in r366664 causes the following infinite > loop shortly after boot: > > ------ > > MAP: No valid partition found at map/rootfs.uzip > Warning: no time-of-day clock registered, system time will not be set > accurately > start_init: trying /sbin/init > BAD_PAGE_FAULT: pid 1 tid 100001 (init), uid 0: pc 0x4042c320 got a read > fault (type 0x2) at 0x2e3a0 > Trapframe Register Dump: > zero: 0 at: 0 v0: 0 v1: 0 > a0: 0x1af34 a1: 0 a2: 0 a3: 0x7fffeff0 > t0: 0 t1: 0 t2: 0 t3: 0 > t4: 0 t5: 0 t6: 0 t7: 0 > t8: 0 t9: 0x152e8 s0: 0x7fffee84 s1: 0 > s2: 0 s3: 0 s4: 0 s5: 0 > s6: 0 s7: 0 k0: 0 k1: 0 > gp: 0x362c0 sp: 0x7fffedf0 s8: 0 ra: 0x40417df0 > sr: 0xf413 mullo: 0 mulhi: 0 badvaddr: > 0x2e3a0 > cause: 0xffffffff80000008 pc: 0x4042c31c > Page table info for pc address 0x4042c320: pde = 0x80712000, pte = > 0xa002065a > Dumping 4 words starting at pc address 0x4042c320: > 8f9980e0 80820000 10400067 00809825 > Page table info for bad address 0x2e3a0: pde = 0, pte = 0 > > ------ > > I'm not yet sure why, but until I figure it out with the mips64/cheri > folk this should be reverted. > > This should only use -O on GCC generated code for MIPS platforms. > > Tested: > > * QCA934x (mips74k) - WDR-3600/WDR-4300 APs > > Differential Revision: https://reviews.freebsd.org/D28122 > --- > share/mk/sys.mk | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/share/mk/sys.mk b/share/mk/sys.mk > index 8f456b28593a..72f458397683 100644 > --- a/share/mk/sys.mk > +++ b/share/mk/sys.mk > @@ -166,7 +166,14 @@ CC ?= c89 > CFLAGS ?= -O > .else > CC ?= cc > +.if ${MACHINE_CPUARCH} == "mips" && ${COMPILER_TYPE} == "gcc" > +# Note: there are currently issues generating code gcc-6.x targeting > +# code for at least mips32. The system hits infinite page faults > +# when starting /sbin/init if -O2 is used. > +CFLAGS ?= -O -pipe > +.else > CFLAGS ?= -O2 -pipe > +.endif > .if defined(NO_STRICT_ALIASING) > CFLAGS += -fno-strict-aliasing > .endif > _______________________________________________ > dev-commits-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all > To unsubscribe, send any mail to > "dev-commits-src-all-unsubscribe@freebsd.org" > -- Mateusz Guzik