From owner-svn-src-user@FreeBSD.ORG  Sat Apr 21 06:29:45 2012
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 109E5106566B;
	Sat, 21 Apr 2012 06:29:45 +0000 (UTC) (envelope-from hrs@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id F114A8FC12;
	Sat, 21 Apr 2012 06:29:44 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q3L6TilV075140;
	Sat, 21 Apr 2012 06:29:44 GMT (envelope-from hrs@svn.freebsd.org)
Received: (from hrs@localhost)
	by svn.freebsd.org (8.14.4/8.14.4/Submit) id q3L6Ti2a075138;
	Sat, 21 Apr 2012 06:29:44 GMT (envelope-from hrs@svn.freebsd.org)
Message-Id: <201204210629.q3L6Ti2a075138@svn.freebsd.org>
From: Hiroki Sato <hrs@FreeBSD.org>
Date: Sat, 21 Apr 2012 06:29:44 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-user@freebsd.org
X-SVN-Group: user
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r234532 - user/hrs/ipv6/sys/dev/usb
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
	src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Apr 2012 06:29:45 -0000

Author: hrs
Date: Sat Apr 21 06:29:44 2012
New Revision: 234532
URL: http://svn.freebsd.org/changeset/base/234532

Log:
  - Fix ifname matching.
  - Return non-zero status when unit < 0.

Modified:
  user/hrs/ipv6/sys/dev/usb/usb_pf.c

Modified: user/hrs/ipv6/sys/dev/usb/usb_pf.c
==============================================================================
--- user/hrs/ipv6/sys/dev/usb/usb_pf.c	Sat Apr 21 06:10:18 2012	(r234531)
+++ user/hrs/ipv6/sys/dev/usb/usb_pf.c	Sat Apr 21 06:29:44 2012	(r234532)
@@ -129,7 +129,7 @@ usbpf_ifname2ubus(const char *ifname)
 	int unit;
 	int error;
 
-	if (strncmp(ifname, USBUSNAME, sizeof(USBUSNAME)) <= 0)
+	if (strncmp(ifname, USBUSNAME, sizeof(USBUSNAME) - 1) != 0)
 		return (NULL);
 	error = ifc_name2unit(ifname, &unit);
 	if (error || unit < 0)
@@ -167,8 +167,10 @@ usbpf_clone_create(struct if_clone *ifc,
 	struct usb_bus *ubus;
 
 	error = ifc_name2unit(name, &unit);
-	if (error || unit < 0)
+	if (error)
 		return (error);
+	if (unit < 0)
+		return (EINVAL);
 
 	ubus = usbpf_ifname2ubus(name);
 	if (ubus == NULL)