From owner-svn-src-head@FreeBSD.ORG Wed Apr 29 19:11:18 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9AEDE48C; Wed, 29 Apr 2015 19:11:18 +0000 (UTC) Received: from mail-pd0-x235.google.com (mail-pd0-x235.google.com [IPv6:2607:f8b0:400e:c02::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 694F01ABC; Wed, 29 Apr 2015 19:11:18 +0000 (UTC) Received: by pdbnk13 with SMTP id nk13so36605724pdb.0; Wed, 29 Apr 2015 12:11:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :message-id:references:to; bh=ZWtCfVbT7yrzmf5YWTuzaGxaAMroRhu8U6uSsKvHom8=; b=gS4/ngBOyk4D3RosirYL5fHiP1qGHaqWoTDE7jiCuC4EBXMpbcKFwYb33vfNEvickB 4dzGmH5mGbWKLF3Z1MBwGbDyAbnT4yw+bs2Ng/mI2XzpKTTzSKy7EVfSYeCJmUzvKXCs BELAjntK/KJkeo4TzYAfGP6mV5Ea08b/cFc0yKBdrLzNk597BPuCJWz2bVGhv9Rkfq6b 53XnGaqxvZ7YUFH92COb4h5baShwIfIduFzD36VltncbJocbAmOOSG2fzkmeaqidR3tt wW2kFV/bXVxpeijk9zJPD4e7VOklxLJRR6c04giCs4Np/V7E2PRAKSKwDwYaLCHGb/h7 IBZg== X-Received: by 10.70.134.35 with SMTP id ph3mr968304pdb.91.1430334677872; Wed, 29 Apr 2015 12:11:17 -0700 (PDT) Received: from ?IPv6:2601:8:ab80:7d6:857d:cd13:79bf:f40d? ([2601:8:ab80:7d6:857d:cd13:79bf:f40d]) by mx.google.com with ESMTPSA id ho10sm18477936pbc.27.2015.04.29.12.11.16 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 29 Apr 2015 12:11:16 -0700 (PDT) Subject: Re: svn commit: r282211 - head/tests/freebsd_test_suite Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_C5515D5E-6900-4BF0-BC59-F9F39EEA1B00"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b6 From: Garrett Cooper In-Reply-To: <20150429112944.GI546@FreeBSD.org> Date: Wed, 29 Apr 2015 12:11:13 -0700 Cc: Garrett Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <068339F0-E6F0-4D10-B35D-AB4929521371@gmail.com> References: <201504290856.t3T8uuHF070908@svn.freebsd.org> <20150429112944.GI546@FreeBSD.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.1878.6) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2015 19:11:18 -0000 --Apple-Mail=_C5515D5E-6900-4BF0-BC59-F9F39EEA1B00 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On Apr 29, 2015, at 4:29, Gleb Smirnoff wrote: > On Wed, Apr 29, 2015 at 08:56:56AM +0000, Garrett Cooper wrote: > G> Author: ngie > G> Date: Wed Apr 29 08:56:56 2015 > G> New Revision: 282211 > G> URL: https://svnweb.freebsd.org/changeset/base/282211 > G> > G> Log: > G> ATF_REQUIRE_KERNEL_MODULE: use atf_skip, not ATF_REQUIRE_MSG so = the testcase > G> no longer bombs out > G> PLAIN_REQUIRE_KERNEL_MODULE: use printf + _exit, no err so the = testcase no > G> longer bombs out if it prints to stderr > G> > G> MFC after: 5 days >=20 > This breaks buildworld since atf_skip() is a shell function, not a C = one: >=20 > glebius@behemoth:/usr/src/head/contrib/atf:|>grep -r atf_skip atf-c > glebius@behemoth:/usr/src/head/contrib/atf:|>grep -r atf_skip atf-sh/ > atf-sh/atf-sh.3:.Nm atf_skip , Yeah. I should really stop committing things after midnight and should = have gotten CRs/produced tests which would have proved that my code was = broken twice :(. Fixed in r282244.. --Apple-Mail=_C5515D5E-6900-4BF0-BC59-F9F39EEA1B00 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVQSzSAAoJEMZr5QU6S73e9t8H/1Xk9ERJIPpR+g/TZ9zpUhpW pExsXPGM3qwH67kSTQ6RS6ic7gPsfJBvNruX+gqfT5jeHVMfJDtgHlQ9pPzJjYu/ Jwqlo9ttPT7spiXd/KGnhaYk7w2TaYV8sEPpZRD2xIYddTokSBkFF6+WvpHn1Ted k8jCUJBb1t2/Twcbn9C+Ck5x2aa9Ir5FmMhGga8oLB48VB5dnXKUwF3ZX91+P1ts MGJP5MsOiPpx0L5AJR/MdRxbjqGB1brxXE1JkL0ZLOXKitYkj4wuuJC8n0fHCUGV OdO+74WXLeilNKGMZABjgR5W1ytcNOyy6H6rKoFvTcng8V4lGbLxOsmQLtvA/Vg= =Yp4W -----END PGP SIGNATURE----- --Apple-Mail=_C5515D5E-6900-4BF0-BC59-F9F39EEA1B00--