From owner-svn-ports-head@freebsd.org Mon Jan 18 15:19:44 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0CCBAA872CB; Mon, 18 Jan 2016 15:19:44 +0000 (UTC) (envelope-from olgeni@FreeBSD.org) Received: from olgeni.olgeni.com (host-156-246-171-31.cloudsigma.com [31.171.246.156]) by mx1.freebsd.org (Postfix) with ESMTP id CAEFB1FC3; Mon, 18 Jan 2016 15:19:43 +0000 (UTC) (envelope-from olgeni@FreeBSD.org) Received: from [10.0.2.15] (unknown [5.8.101.242]) by olgeni.olgeni.com (Postfix) with ESMTPSA id 5EE2DD793B; Mon, 18 Jan 2016 16:10:24 +0100 (CET) Date: Mon, 18 Jan 2016 16:10:23 +0100 (CET) From: Jimmy Olgeni X-X-Sender: olgeni@backoffice.olgeni.com To: Alexey Dokuchaev cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r404810 - head/devel/elixir-timex In-Reply-To: <20160113153748.GA38723@FreeBSD.org> Message-ID: References: <201512300841.tBU8fsYI090905@repo.freebsd.org> <20160113153748.GA38723@FreeBSD.org> User-Agent: Alpine 2.20 (BSF 67 2015-01-07) X-OpenPGP-KeyID: 0xFCDB3E82F778D8D7 X-OpenPGP-Fingerprint: EE37 B427 91C5 7707 EC54 064A FCDB 3E82 F778 D8D7 X-OpenPGP-URL: http://olgeni.olgeni.com/~olgeni/pgp/olgeni@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jan 2016 15:19:44 -0000 On Wed, 13 Jan 2016, Alexey Dokuchaev wrote: > On Wed, Dec 30, 2015 at 08:41:54AM +0000, Jimmy Olgeni wrote: > > New Revision: 404810 > > URL: https://svnweb.freebsd.org/changeset/ports/404810 > > > > Log: > > Upgrade devel/elixir-timex to version 1.0.0. > > > > [...] > > @@ -1,7 +1,8 @@ > > # $FreeBSD$ > > > > PORTNAME= timex > > -DISTVERSION= 1.0.0-rc4 > > +PORTVERSION= 1.0.0 > > +PORTEPOCH= 1 > > Why did you bump port epoch here? DISTVERSION ensures that resulting > PORTVERSION is correctly mangled, and used for -betas and -rcs because > it allows seamless update to subsequent .0 releases: > > $ make -V PORTVERSION DISTVERSION=1.0.0-rc4 > 1.0.0.r4 > $ pkg version -t 1.0.0.r4 1.0.0 > < I knew about DISTVERSION, but then I figured that 1.0.0.r4 would be greater than 1.0.0 in the version comparison, and I didn't think about pkg version -t. And I even thought about it. I surely made a couple more of these around the same time :( > What's even more strange is that I've made a very similar complaint to > cy@ on Decemlber 9th WRT r403347. All committers should read svn-* lists, > how come you've missed it? :-( I try to keep up to date and star useful messages from svn-* for later reference, but between two jobs sometimes time runs short and I miss a batch. Having to say things twice is pretty much like pressing ^T on Linux, so I do get your point. Now I made a sieve rule to make sure that all replies to svn-* end up directly into my INBOX, so I can see at a glance if there are any comments to commit messages. Seems to be working so far. In the meantime, thanks a lot for keeping an eye on things :) -- jimmy