From owner-svn-src-all@FreeBSD.ORG Tue Mar 31 15:37:03 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A140A73D; Tue, 31 Mar 2015 15:37:03 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 768226D7; Tue, 31 Mar 2015 15:37:03 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net [173.54.116.245]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 53FF1B9B0; Tue, 31 Mar 2015 11:37:02 -0400 (EDT) From: John Baldwin To: Randall Stewart Subject: Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys Date: Tue, 31 Mar 2015 09:36:39 -0400 Message-ID: <3203943.oAr2O9rG4a@ralph.baldwin.cx> User-Agent: KMail/4.14.2 (FreeBSD/10.1-STABLE; KDE/4.14.2; amd64; ; ) In-Reply-To: References: <201503281250.t2SCoOkt020297@svn.freebsd.org> <3218826.nq4nR2EqCz@ralph.baldwin.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 31 Mar 2015 11:37:02 -0400 (EDT) Cc: Davide Italiano , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2015 15:37:03 -0000 On Monday, March 30, 2015 04:21:03 PM Randall Stewart wrote: > John: > > As I just said, Warner and I feel we can get by with making the int -> short/short so > we preserver the KPI and at the same time achieve the objective .. > > My big concern was no intel platforms but Warner gave me a green light there ;-) Technically this still breaks the KBI (in that existing drivers using callout_pending(), callout_active(), and callout_deactivate() will not do the correct thing). OTOH, you can't preserve that and still fix the race (well, unless you do locking in callout_deactivate() which you might consider for an MFC even if you didn't do it in HEAD if the KBI breakage is severe enough). -- John Baldwin